oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix bad override of isLocked inside WebGUI::Asset::Post::Thread

Browse source
This commit is contained in:
Colin Kuskie 2007-04-26 23:11:15 +00:00
parent abdb789902
commit 885a369c67
3 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -1,5 +1,6 @@
7.3.16 7.3.16
- fix: The POD of Form::Image is faulty (perlDreamer Consulting, LLC) - fix: The POD of Form::Image is faulty (perlDreamer Consulting, LLC)
- fix: Method name clash between WebGUI::Asset::Post::Thread and WebGUI::AssetVersioning (perlDreamer Consulting, LLC)
- fix: Images in Collaboration Systems were broken in 7.3.15 - fix: Images in Collaboration Systems were broken in 7.3.15

13
docs/gotcha.txt
View file

@ -7,6 +7,19 @@ upgrading from one version to the next, or even between multiple
versions. Be sure to heed the warnings contained herein as they will versions. Be sure to heed the warnings contained herein as they will
save you many hours of grief. save you many hours of grief.
7.3.16
--------------------------------------------------------------------
* There was an inadvertent override of the Asset method isLocked inside
of WebGUI::Asset::Post::Thread.pm. Normally, isLocked will return true
if the Asset is being edited by another user. However, the isLocked inside
of Thread.pm returned true if the Thread was locked to prevent more
replies from being added to the it.
In 7.3.16, the thread lock method inside Thread.pm was renamed
isThreadLocked. No template variables, field names or database
columsn were changed.
7.3.15 7.3.15
-------------------------------------------------------------------- --------------------------------------------------------------------

8
lib/WebGUI/Asset/Post/Thread.pm
View file

@ -41,7 +41,7 @@ sub archive {
#------------------------------------------------------------------- #-------------------------------------------------------------------
sub canReply { sub canReply {
my $self = shift; my $self = shift;
return !$self->isLocked && $self->getParent->get("allowReplies") && $self->getParent->canPost; return !$self->isThreadLocked && $self->getParent->get("allowReplies") && $self->getParent->canPost;
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -401,13 +401,13 @@ sub getUnsubscribeUrl {
#------------------------------------------------------------------- #-------------------------------------------------------------------
=head2 isLocked ( ) =head2 isThreadLocked ( )
Returns a boolean indicating whether this thread is locked from new posts and other edits. Returns a boolean indicating whether this thread is locked from new posts and other edits.
=cut =cut
sub isLocked { sub isThreadLocked {
my ($self) = @_; my ($self) = @_;
return $self->get("isLocked"); return $self->get("isLocked");
} }
@ -844,7 +844,7 @@ sub view {
$var->{'stick.url'} = $self->getStickUrl; $var->{'stick.url'} = $self->getStickUrl;
$var->{'unstick.url'} = $self->getUnstickUrl; $var->{'unstick.url'} = $self->getUnstickUrl;
$var->{'isLocked'} = $self->isLocked; $var->{'isLocked'} = $self->isThreadLocked;
$var->{'lock.url'} = $self->getLockUrl; $var->{'lock.url'} = $self->getLockUrl;
$var->{'unlock.url'} = $self->getUnlockUrl; $var->{'unlock.url'} = $self->getUnlockUrl;