From 8b9be1e036651abee6d74579a24dd87a375c09ee Mon Sep 17 00:00:00 2001 From: Peter Christiansen Date: Thu, 28 Jul 2011 22:35:18 +0200 Subject: [PATCH] RFE 12207 : www_editThingDataSaveViaAjax should return more info if thingdata fails to be saved. As it is it returns json with an array of error messages: [{error_message=>"some error"},..] But to be able to do anything useful with this. eg. highlighting of form fields whose input is erroneous we should also return the fieldName. This patch takes care of this. --- docs/changelog/7.x.x.txt | 1 + lib/WebGUI/Asset/Wobject/Thingy.pm | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index fba7c0f4c..ddb839f08 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -1,4 +1,5 @@ 7.10.22 + - rfe #12207: Thingy. Field_name info returned by www_editThingDataSaveViaAjax - fixed #12206: Bad Subscription Groups in Duplicated Threads 7.10.21 diff --git a/lib/WebGUI/Asset/Wobject/Thingy.pm b/lib/WebGUI/Asset/Wobject/Thingy.pm index d5e502c97..16edd962f 100644 --- a/lib/WebGUI/Asset/Wobject/Thingy.pm +++ b/lib/WebGUI/Asset/Wobject/Thingy.pm @@ -664,7 +664,7 @@ sub editThingDataSave { } if ($field->{status} eq "required" && ($fieldValue =~ /^\s$/x || $fieldValue eq "" || !(defined $fieldValue))) { push (@errors,{ - "error_message"=>$field->{label}." ".$i18n->get('is required error').".", + "error_message"=>$field->{label}." ".$i18n->get('is required error').".", "field_name"=>$fieldName, }); } if ($field->{status} eq "hidden") { @@ -680,7 +680,7 @@ sub editThingDataSave { unless ( $self->isUniqueEntry($thingId,$fieldName,$fieldValue,$thingDataId)) { push (@errors,{ - "error_message"=>$field->{label}. $i18n->get('needs to be unique error'), + "error_message"=>$field->{label}. $i18n->get('needs to be unique error'),"field_name"=>$fieldName, }); } }