diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index fbcc3aa2b..6cf97b0e8 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -11,6 +11,7 @@ - fixed #11162: Can't delete calendar Related Material Link - fixed #11154: vendor payouts screen borked ( Martin Kamerbeek / Oqapi ) - fixed #11166: Documentation bug - addChild + - fixed #11116: Deleted user's version tags and revisions 7.8.2 - Added scheduled vendor payout workflow activity. (Special thanks to Martin @ Oqapi) diff --git a/lib/WebGUI/Operation/VersionTag.pm b/lib/WebGUI/Operation/VersionTag.pm index dfe5638fb..4f2caedc2 100644 --- a/lib/WebGUI/Operation/VersionTag.pm +++ b/lib/WebGUI/Operation/VersionTag.pm @@ -373,10 +373,9 @@ sub www_commitVersionTag { $session->url->page("op=commitVersionTag;tagId=".$tag->getId), ); $p->setDataByQuery(q{ - SELECT assetData.revisionDate, users.username, asset.assetId, asset.className + SELECT assetData.revisionDate, assetData.revisedBy, asset.assetId, asset.className FROM assetData LEFT JOIN asset ON assetData.assetId = asset.assetId - LEFT JOIN users ON assetData.revisedBy = users.userId WHERE assetData.tagId=? }, undef, undef, @@ -384,8 +383,9 @@ sub www_commitVersionTag { ); foreach my $row ( @{$p->getPageData} ) { - my ( $date, $by, $id, $class) = @{ $row }{ qw( revisionDate username assetId className ) }; + my ( $date, $byUserId, $id, $class) = @{ $row }{ qw( revisionDate revisedBy assetId className ) }; my $asset = WebGUI::Asset->new($session, $id, $class, $date); + my $byUser = WebGUI::User->new( $session, $byUserId ); $output .= '' .$session->icon->view("func=view;revision=".$date, $asset->get("url")) @@ -393,7 +393,7 @@ sub www_commitVersionTag { '.$asset->getTitle.' '.$asset->getName.''.$asset->getName.' '.$session->datetime->epochToHuman($date).' - '.$by.''; + '.$byUser->get('username').''; } $output .= ''.$p->getBarSimple; @@ -809,11 +809,12 @@ sub www_manageRevisionsInTag { . ' ' ; my $p = WebGUI::Paginator->new($session,$session->url->page("op=manageRevisionsInTag;tagId=".$tag->getId)); - $p->setDataByQuery("select assetData.revisionDate, users.username, asset.assetId, asset.className from assetData - left join asset on assetData.assetId=asset.assetId left join users on assetData.revisedBy=users.userId + $p->setDataByQuery("select assetData.revisionDate, assetData.revisedBy, asset.assetId, asset.className from assetData + left join asset on assetData.assetId=asset.assetId where assetData.tagId=?",undef, undef, [$tag->getId]); foreach my $row (@{$p->getPageData}) { - my ($date,$by,$id, $class) = ($row->{revisionDate}, $row->{username}, $row->{assetId}, $row->{className}); + my ($date,$byUserId,$id, $class) = ($row->{revisionDate}, $row->{revisedBy}, $row->{assetId}, $row->{className}); + my $byUser = WebGUI::User->new( $session, $byUserId ); my $asset = WebGUI::Asset->new($session,$id,$class,$date); # A checkbox for delete and move actions my $checkbox = WebGUI::Form::checkbox( $session, { @@ -827,7 +828,7 @@ sub www_manageRevisionsInTag { '.$asset->getTitle.' '.$asset->getName.''.$asset->getName.' '.$session->datetime->epochToHuman($date).' - '.$by.''; + '.$byUser->username.''; } $output .= ''.$p->getBarSimple.WebGUI::Form::formFooter( $session ); $tag = $session->db->getRow("assetVersionTag","tagId",$tag->getId);