oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a test to User.t to make sure it isn't leaking groups.

Browse source 
Update POD in User.pm and Group.pm.
This commit is contained in:
Colin Kuskie 2008-08-01 23:06:23 +00:00
parent 2b8d9a7b48
commit 8d561101b5
3 changed files with 19 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/WebGUI/Group.pm
View file

@ -861,7 +861,8 @@ like IP address, LDAP, dbQuery or scratchFilter.
=head3 withoutExpired
A boolean that if set true will return the users list minus the expired groupings.
A boolean that if set to true will return only the groups that the user is in where
their membership hasn't expired.
=cut

5
lib/WebGUI/User.pm
View file

@ -189,7 +189,10 @@ sub dateCreated {
=head2 delete ( )
Deletes this user.
Deletes this user, removes their user profile data, cleans up their
inbox, removes userSessionScratch data and authentication information,
removes them from any groups they belong to and deletes their
Friend's group.
=cut

18
t/User.t
View file

@ -20,7 +20,7 @@ use WebGUI::Cache;
use WebGUI::User;
use WebGUI::ProfileField;
use Test::More tests => 129; # increment this value for each test you create
use Test::More tests => 130; # increment this value for each test you create
use Test::Deep;
my $session = WebGUI::Test->session;
@ -28,7 +28,8 @@ my $session = WebGUI::Test->session;
my $testCache = WebGUI::Cache->new($session, 'myTestKey');
$testCache->flush;
my $numberOfUsers = $session->db->quickScalar('select count(*) from users');
my $numberOfUsers = $session->db->quickScalar('select count(*) from users');
my $numberOfGroups = $session->db->quickScalar('select count(*) from groups');
my $user;
my $lastUpdate;
@ -556,6 +557,12 @@ $friend->deleteFromGroups([$neighbor->friends->getId]);
$neighbor->profileField('allowPrivateMessages', 'not a valid choice');
is ($neighbor->acceptsPrivateMessages($friend->userId), 1, 'acceptsPrivateMessages: illegal profile field allows messages to be received from anyone');
################################################################
#
# getGroupIdsRecursive
#
################################################################
END {
foreach my $account ($user, $dude, $buster, $buster3, $neighbor, $friend) {
(defined $account and ref $account eq 'WebGUI::User') and $account->delete;
@ -574,8 +581,9 @@ END {
$newProfileField->delete();
$testCache->flush;
my $newNumberOfUsers = $session->db->quickScalar('select count(*) from users');
is ($newNumberOfUsers, $numberOfUsers, 'no new additional users were leaked by this test');
my $newNumberOfUsers = $session->db->quickScalar('select count(*) from users');
my $newNumberOfGroups = $session->db->quickScalar('select count(*) from groups');
is ($newNumberOfUsers, $numberOfUsers, 'no new additional users were leaked by this test');
is ($newNumberOfGroups, $numberOfGroups, 'no new additional groups were leaked by this test');
}