oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead

Browse source
This commit is contained in:
Colin Kuskie 2007-12-05 00:30:43 +00:00
parent 75041656ee
commit 96178fd70c
92 changed files with 209 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/WebGUI/Cache/Database.pm
View file

@ -94,7 +94,7 @@ Retrieve content from the filesystem cache.
sub get {
my $self = shift;
return undef if ($self->session->config->get("disableCache"));
return if ($self->session->config->get("disableCache"));
# getting better performance using native dbi than webgui sql
my $dbh = $self->session->db->dbh;
my $sth = $dbh->prepare("select content from cache where namespace=? and cachekey=? and expires>?");
@ -102,7 +102,7 @@ sub get {
my $data = $sth->fetchrow_arrayref;
$sth->finish;
my $content = $data->[0];
return undef unless ($content);
return unless ($content);
# Storable doesn't like non-reference arguments, so we wrap it in a scalar ref.
return ${thaw($content)};
}

6
lib/WebGUI/Cache/FileCache.pm
View file

@ -105,12 +105,12 @@ Retrieve content from the filesystem cache.
sub get {
my $self = shift;
return undef if ($self->session->config->get("disableCache"));
return if ($self->session->config->get("disableCache"));
my $folder = $self->getFolder;
if (-e $folder."/expires" && -e $folder."/cache" && open(my $FILE,"<",$folder."/expires")) {
my $expires = <$FILE>;
close($FILE);
return undef if ($expires < $self->session->datetime->time());
return if ($expires < $self->session->datetime->time());
my $value;
eval {$value = retrieve($folder."/cache")};
if (ref $value eq "SCALAR") {
@ -119,7 +119,7 @@ sub get {
return $value;
}
}
return undef;
return;
}
#-------------------------------------------------------------------