oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead

Browse source
This commit is contained in:
Colin Kuskie 2007-12-05 00:30:43 +00:00
parent 75041656ee
commit 96178fd70c
92 changed files with 209 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/WebGUI/Image/Graph.pm
View file

@ -602,12 +602,12 @@ sub processConfigurationForm {
my $class = shift;
my $session = shift;
return undef unless ($class->getPluginList($session));
return unless ($class->getPluginList($session));
my $namespace = "WebGUI::Image::".$session->form->process('graphingPlugin');
$namespace =~ s/_/::/g;
return undef unless (isIn($namespace, @{$class->getPluginList($session)}));
return unless (isIn($namespace, @{$class->getPluginList($session)}));
my $graph = $class->load($session, $namespace);

14
lib/WebGUI/Image/Palette.pm
View file

@ -148,7 +148,7 @@ sub getColorIndex {
return $index if ($self->getColor($index)->getId eq $color->getId);
}
return undef;
return;
}
#-------------------------------------------------------------------
@ -372,7 +372,7 @@ sub removeColor {
my $self = shift;
my $paletteIndex = shift;
return undef unless (defined $paletteIndex);
return unless (defined $paletteIndex);
my $color = $self->getColor($paletteIndex);
@ -426,10 +426,10 @@ sub setColor {
my $index = shift;
my $color = shift;
return undef if ($index >= $self->getNumberOfColors);
return undef if ($index < 0);
return undef unless (defined $index);
return undef unless (defined $color);
return if ($index >= $self->getNumberOfColors);
return if ($index < 0);
return unless (defined $index);
return unless (defined $color);
$color->save;
@ -484,7 +484,7 @@ sub setPaletteIndex {
my $self = shift;
my $index = shift;
return undef unless (defined $index);
return unless (defined $index);
$index = ($self->getNumberOfColors - 1) if ($index >= $self->getNumberOfColors);
$index = 0 if ($index < 0);