oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

first round of Perl::Critic cleanups. Do not use return undef, use a bare return instead

Browse source
This commit is contained in:
Colin Kuskie 2007-12-05 00:30:43 +00:00
parent 75041656ee
commit 96178fd70c
92 changed files with 209 additions and 209 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/WebGUI/Operation/AdSpace.pm
View file

@ -54,7 +54,7 @@ Handles a click on an advertisement.
sub www_clickAd {
my $session = shift;
my $id = $session->form->param("id");
return undef unless $id;
return unless $id;
my $url = WebGUI::AdSpace->countClick($session, $id);
$session->http->setRedirect($url);
return "Redirecting to $url";

2
lib/WebGUI/Operation/Help.pm
View file

@ -157,7 +157,7 @@ sub _get {
}
else {
$session->errorHandler->warn("Unable to load help for $namespace -> $id");
return undef;
return;
}
}

2
lib/WebGUI/Operation/SSO.pm
View file

@ -45,7 +45,7 @@ sub www_ssoViaSessionId {
}
}
}
return undef;
return;
}

4
lib/WebGUI/Operation/SpellCheck.pm
View file

@ -41,12 +41,12 @@ An instanciated session object.
sub _getSpeller {
my ($baseDir, $userDir, $homeDir);
my $session = shift;
return undef unless Text::Aspell->can('new');
return unless Text::Aspell->can('new');
my $speller = Text::Aspell->new;
# Get language
my $lang = $session->form->process('lang');
return undef unless (isIn($lang, map {m/^.*?:([^:]*):.*?$/} $speller->list_dictionaries));
return unless (isIn($lang, map {m/^.*?:([^:]*):.*?$/} $speller->list_dictionaries));
# User homedir
my $userId = $session->user->userId;

2
lib/WebGUI/Operation/VersionTag.pm
View file

@ -537,7 +537,7 @@ sub www_setWorkingVersionTag () {
$tag->setWorking();
}
if ($session->form->param("backToSite")) {
return undef;
return;
}
return www_manageVersions($session);
}