diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index df76ebd78..0789dca4e 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -1,4 +1,5 @@ 7.5.3 + - prevent HTML and Macro injection in usernames 7.5.2 - add: Auth modules now accept a "returnUrl" form parameter when logging in diff --git a/lib/WebGUI/Auth.pm b/lib/WebGUI/Auth.pm index cad39b4ec..dcee45760 100644 --- a/lib/WebGUI/Auth.pm +++ b/lib/WebGUI/Auth.pm @@ -78,7 +78,12 @@ sub _isValidUsername { return 1 if($self->userId ne "1" && $self->session->user->username eq $username); - my $i18n = WebGUI::International->new($self->session); + my $i18n = WebGUI::International->new($self->session); + + my $filteredUsername = WebGUI::HTML::filter($username, 'all'); + if ($username ne $filteredUsername) { + $error .= '