From adbec05e971cd7d99696b7514a43a347f4f55694 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Tue, 5 Oct 2010 11:07:53 -0700 Subject: [PATCH] refix the hanging singleton workflow problem with spectre. Fixes bug #10189, again. --- docs/changelog/7.x.x.txt | 1 + lib/WebGUI/Operation/Cron.pm | 3 +++ 2 files changed, 4 insertions(+) diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index 2a2e4388a..16db3bb6b 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -8,6 +8,7 @@ - fixed #11857: make page printable? - fixed #11891: Shop credit not displayed in payment method screen - fixed #11871: Metadata display and criteria builder problems + - fixed #10189: pbworkflow000000000007 Hanging 7.10.1 - fixed #11851: Story Topic: top story variables should be available all the time diff --git a/lib/WebGUI/Operation/Cron.pm b/lib/WebGUI/Operation/Cron.pm index ccfa81e49..08a36a363 100644 --- a/lib/WebGUI/Operation/Cron.pm +++ b/lib/WebGUI/Operation/Cron.pm @@ -308,6 +308,9 @@ sub www_runCronJob { # Run the instance my $error = $instance->start( 1 ); if ($error) { + ##Unable to communicate with spectre. Delete this instance to it does not get stuck. + $session->log->error("Unable to communicate with spectre: $error about taskId: $taskId. Deleting instanceId: ". $instance->getId); + $instance->delete(); return "error"; } $task->delete( 1 ) if ( $task->get("runOnce") );