oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix newsletter containing duplicate threads

Browse source
This commit is contained in:
Graham Knop 2007-09-26 09:44:59 +00:00
parent e7479a11de
commit aec48fa227
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -1,6 +1,7 @@
7.4.8 7.4.8
- fix: Syndicated Content doesn't display all items with multiple feeds in interleaved mode - fix: Syndicated Content doesn't display all items with multiple feeds in interleaved mode
- fix: SQLForm file upload broken - fix: SQLForm file upload broken
- fix: Newsletter can contain duplicate threads
7.4.7 7.4.7
- fix: misspelled i18n in webgui password recovery - fix: misspelled i18n in webgui password recovery

4
lib/WebGUI/Workflow/Activity/SendNewsletters.pm
View file

@ -99,6 +99,7 @@ sub execute {
# find matching threads # find matching threads
my @threads = (); my @threads = ();
my %foundThreads;
$eh->info("Find threads in $assetId matching $userId subscriptions."); $eh->info("Find threads in $assetId matching $userId subscriptions.");
foreach my $subscription (split("\n", $subscriptions)) { foreach my $subscription (split("\n", $subscriptions)) {
$eh->info("Found subscription $subscription"); $eh->info("Found subscription $subscription");
@ -109,10 +110,13 @@ sub execute {
and className like ? and lineage like ? and state = ?", and className like ? and lineage like ? and state = ?",
[$fieldId, '%'.$value.'%', $lastTimeSent, 'WebGUI::Asset::Post::Thread%', $newsletter->get("lineage").'%', 'published']); [$fieldId, '%'.$value.'%', $lastTimeSent, 'WebGUI::Asset::Post::Thread%', $newsletter->get("lineage").'%', 'published']);
while (my ($threadId) = $matchingThreads->array) { while (my ($threadId) = $matchingThreads->array) {
next
if $foundThreads{$threadId};
my $thread = WebGUI::Asset->new($self->session, $threadId); my $thread = WebGUI::Asset->new($self->session, $threadId);
if (defined $thread) { if (defined $thread) {
$eh->info("Found thread $threadId"); $eh->info("Found thread $threadId");
push(@threads, $thread); push(@threads, $thread);
$foundThreads{$threadId} = 1;
} }
else { else {
$eh->error("Couldn't instanciate thread $threadId"); $eh->error("Couldn't instanciate thread $threadId");