From b09009c252c09b35f98e6fd5e40b4f80bbb0f089 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Thu, 12 Jun 2008 17:41:53 +0000 Subject: [PATCH] use exists instead of iterating over all keys and doing string comparisons --- lib/WebGUI/VersionTag.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/WebGUI/VersionTag.pm b/lib/WebGUI/VersionTag.pm index abb85e4cb..d069a45a8 100644 --- a/lib/WebGUI/VersionTag.pm +++ b/lib/WebGUI/VersionTag.pm @@ -511,7 +511,7 @@ sub set { #This is necessary for upgrade prior to 7.5.11 in order to ensure that this field exists. #The if() blocks should be removd once the next branch point is reached. my $assetVersionTagDesc = $self->session->db->buildHashRef('describe assetVersionTag'); - if(grep { $_ =~ /^startTime/ } keys %{$assetVersionTagDesc}) { + if(exists $assetVersionTagDesc->{startTime}) { #If startTime is there, so is endTime. No need for the additional check. $self->{_data}{'startTime' } = $properties->{startTime} || $self->{_data}{startTime} || $startTime; $self->{_data}{'endTime' } = $properties->{endTime} || $self->{_data}{endTime} || $endTime;