From b2317c7136d4fa44151bac0abd19492ac76f92c4 Mon Sep 17 00:00:00 2001 From: Graham Knop Date: Tue, 8 Apr 2008 22:04:06 +0000 Subject: [PATCH] read line by line for thingy import instead of slurp --- lib/WebGUI/Asset/Wobject/Thingy.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/WebGUI/Asset/Wobject/Thingy.pm b/lib/WebGUI/Asset/Wobject/Thingy.pm index 047c991be..9a34a3141 100644 --- a/lib/WebGUI/Asset/Wobject/Thingy.pm +++ b/lib/WebGUI/Asset/Wobject/Thingy.pm @@ -1945,10 +1945,8 @@ thingId=".$session->db->quote($thingId)); open my $importFile,"<",$storage->getPath($file); my $lineNumber = 0; my @data = (); - my @lines = <$importFile>; - close $importFile; - for my $line (@lines){ + while (my $line = <$importFile>) { if ($lineNumber == 0 && $session->form->process('ignoreFirstLine')){ $lineNumber++; $error->info("Skipping first line"); @@ -2024,6 +2022,7 @@ thingId=".$session->db->quote($thingId)); $thingData{updatedById} = $session->user->userId; $self->setCollateral("Thingy_".$thingId,"thingDataId",\%thingData,0,0) if ($thingData{thingDataId}); } + close $importFile; } return $self->www_search($thingId);