From b2f641e7235d0e999ba865f9c0f8183bac10a229 Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Mon, 17 Nov 2008 03:05:41 +0000 Subject: [PATCH] refix the Workflow bug the correct way --- lib/WebGUI/Operation/Workflow.pm | 3 +-- lib/WebGUI/Workflow/Activity.pm | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/WebGUI/Operation/Workflow.pm b/lib/WebGUI/Operation/Workflow.pm index 73337283d..ad1b4b1f0 100644 --- a/lib/WebGUI/Operation/Workflow.pm +++ b/lib/WebGUI/Operation/Workflow.pm @@ -216,8 +216,7 @@ sub www_editWorkflow { my $addmenu = '
'; foreach my $class (@{$workflowActivities->{$workflow->get("type")}}) { my $activity = WebGUI::Workflow::Activity->newByPropertyHashRef($session, {className=>$class}); - next unless defined $activity; - if ($activity->can('getName')) { + if (defined $activity) { $addmenu .= 'getId).'">'.$activity->getName."
\n"; } else { diff --git a/lib/WebGUI/Workflow/Activity.pm b/lib/WebGUI/Workflow/Activity.pm index 3eb2649de..aa7e50a4e 100644 --- a/lib/WebGUI/Workflow/Activity.pm +++ b/lib/WebGUI/Workflow/Activity.pm @@ -339,7 +339,7 @@ sub newByPropertyHashRef { return undef unless defined $properties; return undef unless exists $properties->{className}; my $className = $properties->{className}; - eval { WebGUI::Pluggable::load($class) }; + eval { WebGUI::Pluggable::load($className) }; if ($@) { $session->errorHandler->error($@); return undef;