oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added #9289: Extending the "Request Approval For Version Tag" activity (Bernd Kalbfuß-Zimmermann)

Browse source
This commit is contained in:
Doug Bell 2009-04-30 18:02:25 +00:00
parent faca68256c
commit bc2ed6a3c1
3 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -15,6 +15,7 @@
- Added individual shipping requirements to the Sku. - Added individual shipping requirements to the Sku.
- added #10145: Global Head Tags in Settings - added #10145: Global Head Tags in Settings
- added packing to templates, snippets, and head tags. - added packing to templates, snippets, and head tags.
- added #9289: Extending the "Request Approval For Version Tag" activity by reversing the test (Bernd Kalbfuß-Zimmermann)
7.7.4 7.7.4
- rfe: Extend DateTime for Week-Nrs (#9151) - rfe: Extend DateTime for Week-Nrs (#9151)

9
lib/WebGUI/Workflow/Activity/RequestApprovalForVersionTag/ByCommitterGroup.pm
View file

@ -63,6 +63,12 @@ sub definition {
label => $i18n->get( 'committerGroupId label' ), label => $i18n->get( 'committerGroupId label' ),
hoverHelp => $i18n->get( 'committerGroupId description' ), hoverHelp => $i18n->get( 'committerGroupId description' ),
}, },
invertGroupSetting => {
fieldType => "yesNo",
defaultValue => 0,
label => $i18n->get( 'invertGroupSetting label' ),
hoverHelp => $i18n->get( 'invertGroupSetting description' ),
},
}, },
}; };
return $class->SUPER::definition( $session, $definition ); return $class->SUPER::definition( $session, $definition );
@ -86,7 +92,8 @@ sub execute {
my $committedBy = WebGUI::User->new( $self->session, $tag->get( 'committedBy' ) ); my $committedBy = WebGUI::User->new( $self->session, $tag->get( 'committedBy' ) );
# If tag is handled by this activity # If tag is handled by this activity
if ( $committedBy->isInGroup( $self->get( 'committerGroupId' ) ) ) { if ( (!$self->get( 'invertGroupSetting' ) && $committedBy->isInGroup( $self->get( 'committerGroupId' ) ) )
|| ($self->get( 'invertGroupSetting' ) && !$committedBy->isInGroup( $self->get( 'committerGroupId' ) ) ) ) {
return $self->SUPER::execute( $tag, $instance ); return $self->SUPER::execute( $tag, $instance );
} }
else { else {

12
lib/WebGUI/i18n/English/Activity_RequestApprovalForVersionTag_ByCommitterGroup.pm
View file

@ -14,6 +14,18 @@ our $I18N = {
lastUpdated => 1213631384, lastUpdated => 1213631384,
context => q{Description of activity property}, context => q{Description of activity property},
}, },
'invertGroupSetting label' => {
message => q{Invert Group Setting},
lastUpdated => 1232298054,
context => q{Label for activity property},
},
'invertGroupSetting description' => {
message => q{If selected yes, only users that are not members of the selected committer
group will require approval for using this activity. If the committer is a
member of this group, the workflow will continue with the next activity. },
lastUpdated => 1232298054,
context => q{Description of activity property},
},
topicName => { topicName => {
message => q{Request Approval By Committer Group}, message => q{Request Approval By Committer Group},
lastUpdated => 0, lastUpdated => 0,