oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix for bugfix 1066029

Browse source
This commit is contained in:
Colin Kuskie 2004-11-16 05:19:55 +00:00
parent 9188674f2d
commit bd4b09127e
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/WebGUI/Forum/UI.pm
View file

@ -230,7 +230,7 @@ The unique id for the forum.
=cut =cut
sub formatForumSearchURL { sub formatForumSearchURL {
return WebGUI::URL::append($_[0],"forumOp=search&forumId=".$_[1]); return WebGUI::URL::append($_[0],"forumOp=search&forumId=".quote($_[1]));
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -254,7 +254,7 @@ The sort by string. Can be views, rating, date replies, or lastreply.
=cut =cut
sub formatForumSortByURL { sub formatForumSortByURL {
return WebGUI::URL::append($_[0],"forumOp=viewForum&forumId=".$_[1]."&sortBy=".$_[2]); return WebGUI::URL::append($_[0],"forumOp=viewForum&forumId=".quote($_[1])."&sortBy=".$_[2]);
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -274,7 +274,7 @@ The unique id for the forum.
=cut =cut
sub formatForumSubscribeURL { sub formatForumSubscribeURL {
return WebGUI::URL::append($_[0],"forumOp=forumSubscribe&forumId=".$_[1]); return WebGUI::URL::append($_[0],"forumOp=forumSubscribe&forumId=".quote($_[1]));
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -294,7 +294,7 @@ The unique id for the forum.
=cut =cut
sub formatForumUnsubscribeURL { sub formatForumUnsubscribeURL {
return WebGUI::URL::append($_[0],"forumOp=forumUnsubscribe&forumId=".$_[1]); return WebGUI::URL::append($_[0],"forumOp=forumUnsubscribe&forumId=".quote($_[1]));
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -314,7 +314,7 @@ The unique id for the forum.
=cut =cut
sub formatForumURL { sub formatForumURL {
return WebGUI::URL::append($_[0],"forumOp=viewForum&forumId=".$_[1]); return WebGUI::URL::append($_[0],"forumOp=viewForum&forumId=".quote($_[1]));
} }
@ -382,7 +382,7 @@ The unique id for the forum.
=cut =cut
sub formatNewThreadURL { sub formatNewThreadURL {
return WebGUI::URL::append($_[0],"forumOp=post&forumId=".$_[1]); return WebGUI::URL::append($_[0],"forumOp=post&forumId=".quote($_[1]));
} }
#------------------------------------------------------------------- #-------------------------------------------------------------------
@ -941,7 +941,7 @@ sub forumOp {
my $thread = WebGUI::Forum::Thread->new($session{form}{forumThreadId}); my $thread = WebGUI::Forum::Thread->new($session{form}{forumThreadId});
$forumId = $thread->get("forumId"); $forumId = $thread->get("forumId");
} }
if ($forumId != $caller->{forumId}) { if ($forumId ne $caller->{forumId}) {
WebGUI::ErrorHandler::security("view a forum (".$caller->{forumId}.") that does not belong to the calling object (".$caller->{callback}.")"); WebGUI::ErrorHandler::security("view a forum (".$caller->{forumId}.") that does not belong to the calling object (".$caller->{callback}.")");
return WebGUI::Privilege::insufficient(); return WebGUI::Privilege::insufficient();
} }
@ -1024,7 +1024,7 @@ sub getForumTemplateVars {
} else { } else {
$query .= "lastPostDate desc"; $query .= "lastPostDate desc";
} }
my $p = WebGUI::Paginator->new(WebGUI::URL::append($callback,"forumOp=viewForum&forumId=".$forum->get("forumId")),$forum->get("threadsPerPage")); my $p = WebGUI::Paginator->new(WebGUI::URL::append($callback,"forumOp=viewForum&forumId=".quote($forum->get("forumId"))),$forum->get("threadsPerPage"));
$p->setDataByQuery($query); $p->setDataByQuery($query);
$var{firstPage} = $p->getFirstPageLink; $var{firstPage} = $p->getFirstPageLink;
$var{lastPage} = $p->getLastPageLink; $var{lastPage} = $p->getLastPageLink;
@ -2048,7 +2048,7 @@ sub www_search {
my $query = "select a.forumPostId, a.subject, a.userId, a.username, a.dateOfPost from forumPost a left join forumThread b my $query = "select a.forumPostId, a.subject, a.userId, a.username, a.dateOfPost from forumPost a left join forumThread b
on a.forumThreadId=b.forumThreadId where b.forumId=".quote($forum->get("forumId"))." and on a.forumThreadId=b.forumThreadId where b.forumId=".quote($forum->get("forumId"))." and
(a.status='approved' or a.status='archived') and $constraints order by a.dateOfPost desc"; (a.status='approved' or a.status='archived') and $constraints order by a.dateOfPost desc";
my $p = WebGUI::Paginator->new(WebGUI::URL::append($caller->{callback},"forumOp=search&doit=1&forumId=".$forum->get("forumId")), $numResults); my $p = WebGUI::Paginator->new(WebGUI::URL::append($caller->{callback},"forumOp=search&doit=1&forumId=".quote($forum->get("forumId"))), $numResults);
$p->setDataByQuery($query) if $constraints; $p->setDataByQuery($query) if $constraints;
my @post_loop; my @post_loop;
foreach my $row (@{$p->getPageData}) { foreach my $row (@{$p->getPageData}) {