oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Convert VersionTag to use newById instead of new, since new cannot dispatch to any class but the one that invoked it.

Browse source
This commit is contained in:
Colin Kuskie 2010-01-20 20:15:46 -08:00
parent fcd68c93ac
commit bfedba82dd
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
lib/WebGUI/VersionTag.pm
View file

@ -308,11 +308,11 @@ sub getAssets {
if ($options->{onlyPending}) {
$pending = " and assetData.status='pending' ";
}
my $sth = $self->session->db->read("select asset.assetId,asset.className,assetData.revisionDate from assetData left join asset on asset.assetId=assetData.assetId where assetData.tagId=? ".$pending." order by ".$sort." ".$direction, [$self->getId]);
while (my ($id,$class,$version) = $sth->array) {
my $asset = WebGUI::Asset->new($self->session,$id,$class,$version);
my $sth = $self->session->db->read("select asset.assetId,assetData.revisionDate from assetData left join asset on asset.assetId=assetData.assetId where assetData.tagId=? ".$pending." order by ".$sort." ".$direction, [$self->getId]);
while (my ($id,$version) = $sth->array) {
my $asset = WebGUI::Asset->newById($self->session,$id,$version);
unless (defined $asset) {
$self->session->errorHandler->error("Asset $id $class $version could not be instanciated by version tag ".$self->getId.". Perhaps it is corrupt.");
$self->session->errorHandler->error("Asset $id $version could not be instanciated by version tag ".$self->getId.". Perhaps it is corrupt.");
next;
}
push(@assets, $asset);