oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

added: Better error messages when SQL Report lacks a query

Browse source
This commit is contained in:
Graham Knop 2008-03-31 08:22:37 +00:00
parent 6aa48c8c95
commit c16224f6a2
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -11,6 +11,7 @@
- fixed: Unable to communicate with Spectre under alternate locales
- fixed: Project Manager can't track non-integer durations
- fixed: Unable to edit CS posts that were denied as a normal user
- added: Better error messages when SQL Report lacks a query (William McKee, Knowmad Technologies)
7.5.8
- moved Gallery utility methods to WebGUI::Utility::Gallery

8
lib/WebGUI/Asset/Wobject/SQLReport.pm
View file

@ -577,6 +577,12 @@ sub _processQuery {
$prefix = 'query'.$nr.'.';
}
if (! $self->{_query}{$nr}{dbQuery}) {
$self->session->errorHandler->warn("No query specified for query $nr on '" . $self->getId . "'");
push @{$self->{_debug_loop}}, { 'debug.output' => "No query specfied for query $nr" };
return \%var;
}
# Parse placeholder parameters
my $placeholderParams = $self->_parsePlaceholderParams($self->{_query}{$nr}{placeholderParams});
@ -593,7 +599,7 @@ sub _processQuery {
push(@{$self->{_debug_loop}},{'debug.output'=>$i18n->get('debug placeholder parameters').join(",",@$placeholderParams)});
my $dbLink = WebGUI::DatabaseLink->new($self->session,$self->{_query}{$nr}{databaseLinkId});
if (!$dbLink) {
$self->session->errorHandler->error("Could not find database link '".$self->{_query}{$nr}{databaseLinkId}."'. Has it been created?");
$self->session->errorHandler->error("Could not find database link for query #$nr: '".$self->{_query}{$nr}{databaseLinkId}."'. Has it been created?");
push @{$self->{_debug_loop}}, { 'debug.output' => 'Could not find database link'};
return \%var;
}