diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt index bf3d1fdf6..fae32e2fc 100644 --- a/docs/changelog/7.x.x.txt +++ b/docs/changelog/7.x.x.txt @@ -1,6 +1,7 @@ 7.7.0 - fixed: Template parser cannot be set - fixed #9836: Matrix: Group to Add Listings is missing + - fixed #9924: WebGUI::Shop::Cart::readyForCheckout fails randomly (Henry Tang, Long Term Results B.v.) - fixed #9873: third-> first in post template help - fixed #9892: Typo in "Default Gallery View Album" Template [TEMPLATE] diff --git a/lib/WebGUI/Shop/AddressBook.pm b/lib/WebGUI/Shop/AddressBook.pm index c2e7dcfe0..61d753630 100644 --- a/lib/WebGUI/Shop/AddressBook.pm +++ b/lib/WebGUI/Shop/AddressBook.pm @@ -147,7 +147,7 @@ An address object's unique id. sub getAddress { my ($self, $addressId) = @_; - my $id = ref $self; + my $id = id $self; unless (exists $addressCache{$id}{$addressId}) { $addressCache{$id}{$addressId} = WebGUI::Shop::Address->new($self, $addressId); } diff --git a/lib/WebGUI/Shop/Cart.pm b/lib/WebGUI/Shop/Cart.pm index 2342a810e..82c4e6135 100644 --- a/lib/WebGUI/Shop/Cart.pm +++ b/lib/WebGUI/Shop/Cart.pm @@ -260,7 +260,7 @@ Returns a reference to the address book for the user who's cart this is. sub getAddressBook { my $self = shift; - my $id = ref $self; + my $id = id $self; unless (exists $addressBookCache{$id}) { $addressBookCache{$id} = WebGUI::Shop::AddressBook->newBySession($self->session); } @@ -297,7 +297,6 @@ sub getItem { unless (defined $itemId && $itemId =~ m/^[A-Za-z0-9_-]{22}$/) { WebGUI::Error::InvalidParam->throw(error=>"Need an itemId."); } - my $id = ref $self; my $item = WebGUI::Shop::CartItem->new($self, $itemId); return $item; } diff --git a/lib/WebGUI/Shop/CartItem.pm b/lib/WebGUI/Shop/CartItem.pm index c1c8c0e31..ab662d8b5 100644 --- a/lib/WebGUI/Shop/CartItem.pm +++ b/lib/WebGUI/Shop/CartItem.pm @@ -173,7 +173,6 @@ Returns an instanciated WebGUI::Asset::Sku object for this cart item. sub getSku { my ($self) = @_; - my $id = ref $self; my $asset = ''; $asset = WebGUI::Asset->newByDynamicClass($self->cart->session, $self->get("assetId")); $asset->applyOptions($self->get("options"));