oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Input validation tests for importTaxData.

Browse source
This commit is contained in:
Colin Kuskie 2008-02-18 21:23:43 +00:00
parent 95a327ea62
commit c613e38995
7 changed files with 115 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/WebGUI/Shop/Tax.pm
View file

@ -147,8 +147,15 @@ sub getItems {
Import tax information from the specified file in CSV format. The
first line of the file should contain the name of the columns, in
any order. The following lines will contain tax information. Blank
lines and anything following a '#' sign will be ignored.
any order. The first line may not contain comments in it, or
before it.
The following lines will contain tax information. Blank
lines and anything following a '#' sign will be ignored from
the second line of the file, on to the end.
Returns 1 if the import has taken place. This is to help you know
if old data has been deleted and new has been inserted.
=cut
@ -174,12 +181,15 @@ sub importTaxData {
my $line = 1;
while (my $taxRow = <$table>) {
chomp $taxRow;
$taxRow =~ s/\s*#.+$//;
next unless $taxRow;
my @taxRow = WebGUI::Text::splitCSV($taxRow);
croak qq{Error on line $line in file $filePath}
unless scalar @taxRow == 3;
push @taxData, [ @taxRow ];
}
##Okay, if we got this far, then the data looks fine.
return unless scalar @taxData;
$self->session->db->beginTransaction;
$self->session->db->write('delete from tax');
foreach my $taxRow (@taxData) {
@ -188,7 +198,7 @@ sub importTaxData {
$self->add(\%taxRow);
}
$self->session->db->commit;
return;
return 1;
}
#-------------------------------------------------------------------