test fixes and small cleanups

This commit is contained in:
Graham Knop 2009-03-26 21:44:55 +00:00
parent cab6c18372
commit c91878c9a3
5 changed files with 13 additions and 18 deletions

View file

@ -359,7 +359,6 @@ delete the add if it gets refunded
sub onRefund {
my $self = shift;
my $item = shift;
my $ad;
my $iterator = WebGUI::AssetCollateral::Sku::Ad::Ad->getAllIterator($self->session,{
constraints => [ { "transactionItemId = ?" => $item->getId } ],
@ -367,7 +366,6 @@ sub onRefund {
my $crud = $iterator->();
my $ad = WebGUI::AdSpace::Ad->new($self->session,$crud->get('adId'));
$ad = WebGUI::AdSpace::Ad->new($self->session,$crud->get('adId'));
my $clicks = $ad->get('clicksBought') - $crud->get('clicksPurchased');
my $impressions = $ad->get('impressionsBought') - $crud->get('impressionsPurchased') ;
$ad->set({

View file

@ -1011,10 +1011,9 @@ sub www_getCompareFormData {
my $sort = shift || $session->scratch->get('matrixSort') || $self->get('defaultSort');
my $sortDirection = ' desc';
my @results;
my @listingIds = $self->session->form->checkList("listingId");
my @listingIds = $session->form->checkList("listingId");
$self->session->http->setMimeType("application/json");
$session->http->setMimeType("application/json");
my (@searchParams,@searchParams_sorted,@searchParamList,$searchParamList);
if($form->process("search")){
@ -1056,10 +1055,9 @@ assetData.revisionDate
and status='approved'
order by ".$sort.$sortDirection;
my $sth = $self->session->db->read($sql,[$self->getId]);
my $sth = $session->db->read($sql,[$self->getId]);
my @results;
my $gateway = $self->session->config->get("gateway");
if($form->process("search")){
while (my $result = $sth->hashRef) {
my $matrixListing_attributes = $session->db->buildHashRefOfHashRefs("
@ -1084,7 +1082,7 @@ assetData.revisionDate
}
}
$result->{assetId} =~ s/-/_____/g;
$result->{url} = $gateway."/".$result->{url};
$result->{url} = $session->url->gateway($result->{url});
push @results, $result;
}
}else{
@ -1093,7 +1091,7 @@ assetData.revisionDate
if(WebGUI::Utility::isIn($result->{assetId},@listingIds)){
$result->{checked} = 'checked';
}
$result->{url} = $gateway."/".$result->{url};
$result->{url} = $session->url->gateway($result->{url});
push @results, $result;
}
}

View file

@ -20,7 +20,7 @@ use base 'WebGUI::Crud';
#------------------------------------------------
=head crud_definition
=head1 crud_definition
defines the field this crud will contain