oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make test pass when there are no failures. Yes, it does seem strange.

Browse source
This commit is contained in:
Colin Kuskie 2009-02-03 22:00:00 +00:00
parent 7365d116be
commit ca208699a4
1 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
t/hardcodedExtras.t
View file

@ -16,6 +16,7 @@ use lib "$FindBin::Bin/lib"; ##t/lib
use WebGUI::Test; use WebGUI::Test;
use WebGUI::Session; use WebGUI::Session;
use WebGUI::Asset::Template; use WebGUI::Asset::Template;
use WebGUI::Asset::Snippet;
#The goal of this test is to find hard coded extras paths in templates or in #The goal of this test is to find hard coded extras paths in templates or in
#the extraHeadTags of any assets. #the extraHeadTags of any assets.
@ -47,6 +48,20 @@ TEMPLATE: while (my $templateAsset = $getATemplate->()) {
} }
} }
my $getASnippet = WebGUI::Asset::Snippet->getIsa($session);
SNIPPET: while (my $snippetAsset = $getASnippet->()) {
my $snippet = $snippetAsset->get('snippet');
next SNIPPET unless $snippet;
if ($snippet =~ m!$hardcodedExtras! ) {
push @hardcodedExtras, {
url => $snippetAsset->getUrl,
id => $snippetAsset->getId,
title => $snippetAsset->getTitle,
type => 'Snippet',
}
}
}
my $getAnAsset = WebGUI::Asset->getIsa($session); my $getAnAsset = WebGUI::Asset->getIsa($session);
ASSET: while (my $asset = $getAnAsset->()) { ASSET: while (my $asset = $getAnAsset->()) {
my $headTags = $asset->get('extraHeadTags'); my $headTags = $asset->get('extraHeadTags');
@ -63,7 +78,13 @@ ASSET: while (my $asset = $getAnAsset->()) {
$numTests = scalar @hardcodedExtras; $numTests = scalar @hardcodedExtras;
plan tests => $numTests; if ($numTests) {
plan tests => $numTests;
}
else {
plan tests => 1;
ok(1, 'All assets pass');
}
foreach my $template ( @hardcodedExtras ) { foreach my $template ( @hardcodedExtras ) {
fail( fail(