Change the showing of hidden pages by the SiteIndex to be configurable. Fixes RFE #11044.

Also, change the SiteIndex to use an iterator.

docs/changelog/7.x.x.txt

@@ -5,6 +5,7 @@
  - fixed #11372: All Search Forms should use GET
  - fixed #11373: Problem creating FilePump bundles
  - fixed #11374: USPS shipping drivers take 3 minutes to timeout
+ - fixed #11044: Optionally include hidden pages in sitemap.xml
 
 7.8.10
  - fixed #11332: Pagination in webgui.org forum urls

docs/gotcha.txt

@@ -11,6 +11,11 @@ save you many hours of grief.
 --------------------------------------------------------------------
      * WebGUI now requires DateTime::Format::HTTP, to handle parsing HTTP dates.
 
+     * The Google sitemap generator in WebGUI was including hidden pages in the list of
+       pages.  This is now configurable, with the default being to NOT show hidden pages.
+       If you wish hidden pages to be shown, then in the config file set showHiddenPages
+       to 1.
+
 7.8.6
 --------------------------------------------------------------------
     * WebGUI now requires LWP 5.833 or higher, to fix a bug in that module.

docs/upgrades/upgrade_7.8.10-7.8.11.pl

@@ -31,6 +31,7 @@ my $quiet; # this line required
 my $session = start(); # this line required
 
 # upgrade functions go here
+addSiteIndexToConfig($session);
 
 finish($session); # this line required
 
@@ -44,6 +45,16 @@ finish($session); # this line required
 #    print "DONE!\n" unless $quiet;
 #}
 
+#----------------------------------------------------------------------------
+# Describe what our function does
+sub addSiteIndexToConfig {
+    my $session = shift;
+    print "\tAdd Site Config indexing section to config file... " unless $quiet;
+    $session->config->set('siteIndex', { showHiddenPages => 0 });
+    # and here's our code
+    print "DONE!\n" unless $quiet;
+}
+
 
 # -------------- DO NOT EDIT BELOW THIS LINE --------------------------------