oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

- Made exipred sessions workflow activity more fault tollerant.

Browse source 
- Made rss fetching more fault tollerant.
This commit is contained in:
JT Smith 2007-02-01 00:26:15 +00:00
parent e1bd43b02e
commit caf859129d
3 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/changelog/7.x.x.txt
View file

@ -14,6 +14,8 @@
- fix: Added better error trapping for WikiMaster - fix: Added better error trapping for WikiMaster
- fix: Wiki causes site to fail - fix: Wiki causes site to fail
- fix: Wiki Error on plainblack.com - fix: Wiki Error on plainblack.com
- Made exipred sessions workflow activity more fault tollerant.
- Made rss fetching more fault tollerant.
- fix: lack of testing for valid object creation - fix: lack of testing for valid object creation
- fix: No mention of intermediate upgrade step in gotcha's - fix: No mention of intermediate upgrade step in gotcha's
- fix: A newly released version of Html::Template fixes a bug with global - fix: A newly released version of Html::Template fixes a bug with global

6
lib/WebGUI/Workflow/Activity/DeleteExpiredSessions.pm
View file

@ -69,14 +69,18 @@ See WebGUI::Workflow::Activity::execute() for details.
sub execute { sub execute {
my $self = shift; my $self = shift;
my $sth = $self->session->db->read("select sessionId from userSession where expires<?",[time()]); my $sth = $self->session->db->read("select sessionId from userSession where expires<?",[time()]);
my $time = time();
while (my ($sessionId) = $sth->array) { while (my ($sessionId) = $sth->array) {
my $session = WebGUI::Session->open($self->session->config->getWebguiRoot, $self->session->config->getFilename, undef, undef, $sessionId, 1); my $session = WebGUI::Session->open($self->session->config->getWebguiRoot, $self->session->config->getFilename, undef, undef, $sessionId, 1);
if (defined $session) { if (defined $session) {
$session->var->end; $session->var->end;
$session->close; $session->close;
} }
if ((time() - $time) > 55) {
$sth->finish;
return $self->WAITING;
}
} }
$sth->finish;
return $self->COMPLETE; return $self->COMPLETE;
} }

4
lib/WebGUI/Workflow/Activity/GetSyndicatedContent.pm
View file

@ -91,8 +91,8 @@ sub execute {
# May need to fix this in the future. # May need to fix this in the future.
my $returnValue = WebGUI::Asset::Wobject::SyndicatedContent::_get_rss_data($self->session, $url); my $returnValue = WebGUI::Asset::Wobject::SyndicatedContent::_get_rss_data($self->session, $url);
unless (defined $returnValue) { unless (defined $returnValue) {
$self->session->errorHandler->error("GetSyndicatedContent Workflow Activity: _get_rss_data returned undef while trying to process syndicated content url $url"); $self->session->errorHandler->error("GetSyndicatedContent Workflow Activity: _get_rss_data returned undef while trying to process syndicated content url $url, which usually indicates an improper URL, or a malformed document");
return $self->ERROR; next;
} }
} }