From cb952501fc535e568db4dfecfa8ffba7ed5561a7 Mon Sep 17 00:00:00 2001
From: Colin Kuskie <colink@perldreamer.com>
Date: Mon, 25 Oct 2010 10:29:16 -0700
Subject: [PATCH] Prevent password fields from autocompleting, which can
 overwrite passwords when editing forms.  Fixes bug #11923.

---
 docs/changelog/7.x.x.txt                  | 1 +
 lib/WebGUI/Asset/Wobject/Collaboration.pm | 2 ++
 lib/WebGUI/Auth/WebGUI.pm                 | 3 ++-
 lib/WebGUI/Operation/User.pm              | 1 +
 4 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt
index c167217b4..5524fea77 100644
--- a/docs/changelog/7.x.x.txt
+++ b/docs/changelog/7.x.x.txt
@@ -2,6 +2,7 @@
  - fixed #11920: Defaul DataForm emails missing entries.
  - fixed #11921: DataForm emails contain 1 table per field
  - fixed #11922: Help tempalte is squatting on a good URL
+ - fixed #11923: Collaboration System Mail Cron Errors
 
 7.10.3
  - fixed #11903: Unnecessary debug in Thingy
diff --git a/lib/WebGUI/Asset/Wobject/Collaboration.pm b/lib/WebGUI/Asset/Wobject/Collaboration.pm
index 555c51da8..7bc75692b 100644
--- a/lib/WebGUI/Asset/Wobject/Collaboration.pm
+++ b/lib/WebGUI/Asset/Wobject/Collaboration.pm
@@ -556,6 +556,7 @@ sub definition {
 			tab=>'mail',
 			label=>$i18n->get("mail account"),
 			hoverHelp=>$i18n->get("mail account help"),
+            extras => 'autocomplete="off"',
 			},
 		mailPassword=>{
 			fieldType=>"password",
@@ -563,6 +564,7 @@ sub definition {
 			tab=>'mail',
 			label=>$i18n->get("mail password"),
 			hoverHelp=>$i18n->get("mail password help"),
+            extras => 'autocomplete="off"',
 			},
 		mailAddress=>{
 			fieldType=>"email",
diff --git a/lib/WebGUI/Auth/WebGUI.pm b/lib/WebGUI/Auth/WebGUI.pm
index ca5f46e28..2417dcf03 100644
--- a/lib/WebGUI/Auth/WebGUI.pm
+++ b/lib/WebGUI/Auth/WebGUI.pm
@@ -400,7 +400,8 @@ sub editUserForm {
    $f->password(
 	name=>"authWebGUI.identifier",
 	label=>$i18n->get(51),
-	value=>"password"
+	value=>"password",
+    extras=>'autocomplete="off"',
 	);
    $f->interval(
 	-name=>"authWebGUI.passwordTimeout",
diff --git a/lib/WebGUI/Operation/User.pm b/lib/WebGUI/Operation/User.pm
index 975b0a054..0278b5f1d 100644
--- a/lib/WebGUI/Operation/User.pm
+++ b/lib/WebGUI/Operation/User.pm
@@ -646,6 +646,7 @@ sub www_editUser {
         -name=>"username",
         -label=>$i18n->get(50),
         -value=>$username
+        -extras=>'autocomplete="off"',
     );
 	my %status;
 	tie %status, 'Tie::IxHash';