Merge branch 'master' into 8-merge

Conflicts:
	docs/gotcha.txt
	docs/upgrades/upgrade_7.9.8-7.9.9.pl
	lib/WebGUI.pm
	lib/WebGUI/Asset.pm
	lib/WebGUI/Asset/Template.pm
	lib/WebGUI/Asset/Wobject/Calendar.pm
	lib/WebGUI/Asset/Wobject/Carousel.pm
	t/Asset/Asset.t
	t/Mail/Send.t
	t/Session/Url.t
	t/lib/WebGUI/Test.pm

docs/changelog/7.x.x.txt

@@ -1,6 +1,20 @@
+7.9.10
+
 7.9.9
  - fixed #11693: Shopping cart does not show for visitor user
  - fixed: missing per-item template variables for the cart.
+ - fixed #11696: WebGUI 7.9.8 gotcha
+ - fixed #11698: Trash dies on missing or bad workflow
+ - fixed #11692: Dates not imported correctly into Thingy
+ - fixed #11672: UTF-Error in message body (from DataForm)
+ - fixed #11709: Shop - i18n error
+ - fixed #11710: Weird license in json.js might be taken as non free
+ - fixed #11708: Activity DeleteExpiredSessions is too slow
+ - fixed #11621: Documentation Error: Methods that accept URLs should indicate whether or not to include Gateway
+ - fixed #11457: Carousel broken
+ - fixed #11455: Wrong use of Extras macro?
+ - fixed #11715: "Empty" user profile fields: not in userProfileData / cannot delete
+ - fixed #11718: Matrix does not URI encode search parameters
 
 7.9.8
  - fixed #11651: First Day of Week is a string...

docs/gotcha.txt

@@ -7,6 +7,7 @@ upgrading from one version to the next, or even between multiple
 versions. Be sure to heed the warnings contained herein as they will
 save you many hours of grief.
 
+<<<<<<< HEAD
 8.0.0
 --------------------------------------------------------------------
  * WebGUI 8 is not API compatible with WebGUI 7. If you have custom
@@ -16,6 +17,11 @@ save you many hours of grief.
  * WebGUI now requires the following modules
     - Moose
     - CHI
+=======
+7.9.8
+--------------------------------------------------------------------
+     * Starting in WebGUI 7.9.4, the Net::Twitter module is required.
+>>>>>>> master
 
 7.9.7
 --------------------------------------------------------------------

docs/upgrades/upgrade_7.9.8-7.9.9.pl

@@ -22,6 +22,7 @@ use Getopt::Long;
 use WebGUI::Session;
 use WebGUI::Storage;
 use WebGUI::Asset;
+use WebGUI::ProfileField;
 
 
 my $toVersion = '7.9.9';
@@ -32,6 +33,9 @@ my $session = start(); # this line required
 
 # upgrade functions go here
 migrateAttachmentsToJson( $session );
+addIndexToUserSessionLog($session);
+addHeightToCarousel($session);
+synchronizeUserProfileTables($session);
 
 finish($session); # this line required
 
@@ -45,6 +49,42 @@ finish($session); # this line required
 #    print "DONE!\n" unless $quiet;
 #}
 
+#----------------------------------------------------------------------------
+# Describe what our function does
+sub addIndexToUserSessionLog {
+    my $session = shift;
+    print "\tAdd index to UserSessionLogTable... " unless $quiet;
+    $session->db->write(q|alter table userLoginLog add index sessionId (sessionId)|);
+    print "DONE!\n" unless $quiet;
+}
+
+#----------------------------------------------------------------------------
+# Describe what our function does
+sub addHeightToCarousel {
+    my $session = shift;
+    print "\tAdd slide height to Carousel... " unless $quiet;
+    $session->db->write(q|alter table Carousel add column slideHeight int(11)|);
+    print "DONE!\n" unless $quiet;
+}
+
+#----------------------------------------------------------------------------
+# Describe what our function does
+sub synchronizeUserProfileTables {
+    my $session = shift;
+    print "\tMake sure that userProfileField, and userProfileData tables are aligned correctly... " unless $quiet;
+    my $dbh         = $session->db->dbh;
+    my $fields = WebGUI::ProfileField->getFields($session);
+    foreach my $field ( @{ $fields } ) {
+        my $columnInfo = $dbh->column_info(undef, undef, 'userProfileData', $field->getId)->fetchrow_hashref();
+        if (! $columnInfo) {
+            printf "\n\t\tDeleting broken field: %s", $field->getId;
+            $session->db->deleteRow('userProfileField', 'fieldName', $field->getId);
+        }
+    }
+
+    print "  ...DONE!\n" unless $quiet;
+}
+
 #----------------------------------------------------------------------------
 # Move Template attachments to JSON collateral
 sub migrateAttachmentsToJson {
@@ -132,6 +172,7 @@ sub start {
 sub finish {
     my $session = shift;
     updateTemplates($session);
+    migrateAttachmentsToJson( $session );
     my $versionTag = WebGUI::VersionTag->getWorking($session);
     $versionTag->commit;
     $session->db->write("insert into webguiVersion values (".$session->db->quote($toVersion).",'upgrade',".time().")");

docs/upgrades/upgrade_7.9.9-7.9.10.pl

@@ -0,0 +1,123 @@
+#!/usr/bin/env perl
+
+#-------------------------------------------------------------------
+# WebGUI is Copyright 2001-2009 Plain Black Corporation.
+#-------------------------------------------------------------------
+# Please read the legal notices (docs/legal.txt) and the license
+# (docs/license.txt) that came with this distribution before using
+# this software.
+#-------------------------------------------------------------------
+# http://www.plainblack.com                     info@plainblack.com
+#-------------------------------------------------------------------
+
+our ($webguiRoot);
+
+BEGIN {
+    $webguiRoot = "../..";
+    unshift (@INC, $webguiRoot."/lib");
+}
+
+use strict;
+use Getopt::Long;
+use WebGUI::Session;
+use WebGUI::Storage;
+use WebGUI::Asset;
+
+
+my $toVersion = '7.9.10';
+my $quiet; # this line required
+
+
+my $session = start(); # this line required
+
+# upgrade functions go here
+
+finish($session); # this line required
+
+
+#----------------------------------------------------------------------------
+# Describe what our function does
+#sub exampleFunction {
+#    my $session = shift;
+#    print "\tWe're doing some stuff here that you should know about... " unless $quiet;
+#    # and here's our code
+#    print "DONE!\n" unless $quiet;
+#}
+
+
+# -------------- DO NOT EDIT BELOW THIS LINE --------------------------------
+
+#----------------------------------------------------------------------------
+# Add a package to the import node
+sub addPackage {
+    my $session     = shift;
+    my $file        = shift;
+
+    print "\tUpgrading package $file\n" unless $quiet;
+    # Make a storage location for the package
+    my $storage     = WebGUI::Storage->createTemp( $session );
+    $storage->addFileFromFilesystem( $file );
+
+    # Import the package into the import node
+    my $package = eval {
+        my $node = WebGUI::Asset->getImportNode($session);
+        $node->importPackage( $storage, {
+            overwriteLatest    => 1,
+            clearPackageFlag   => 1,
+            setDefaultTemplate => 1,
+        } );
+    };
+
+    if ($package eq 'corrupt') {
+        die "Corrupt package found in $file.  Stopping upgrade.\n";
+    }
+    if ($@ || !defined $package) {
+        die "Error during package import on $file: $@\nStopping upgrade\n.";
+    }
+
+    return;
+}
+
+#-------------------------------------------------
+sub start {
+    my $configFile;
+    $|=1; #disable output buffering
+    GetOptions(
+        'configFile=s'=>\$configFile,
+        'quiet'=>\$quiet
+    );
+    my $session = WebGUI::Session->open($webguiRoot,$configFile);
+    $session->user({userId=>3});
+    my $versionTag = WebGUI::VersionTag->getWorking($session);
+    $versionTag->set({name=>"Upgrade to ".$toVersion});
+    return $session;
+}
+
+#-------------------------------------------------
+sub finish {
+    my $session = shift;
+    updateTemplates($session);
+    my $versionTag = WebGUI::VersionTag->getWorking($session);
+    $versionTag->commit;
+    $session->db->write("insert into webguiVersion values (".$session->db->quote($toVersion).",'upgrade',".time().")");
+    $session->close();
+}
+
+#-------------------------------------------------
+sub updateTemplates {
+    my $session = shift;
+    return undef unless (-d "packages-".$toVersion);
+    print "\tUpdating packages.\n" unless ($quiet);
+    opendir(DIR,"packages-".$toVersion);
+    my @files = readdir(DIR);
+    closedir(DIR);
+    my $newFolder = undef;
+    foreach my $file (@files) {
+        next unless ($file =~ /\.wgpkg$/);
+        # Fix the filename to include a path
+        $file       = "packages-" . $toVersion . "/" . $file;
+        addPackage( $session, $file );
+    }
+}
+
+#vim:ft=perl