Modify WebGUI IP fields to use CIDR format instead of a regular expression.
Multiple IPs are separated by commas, whitespace is ignored. In groups, that affects the ipFilter field, User::isInGroup. In settings, that affects Settings::debugIp and Session::ErrorHandler::canShowDebug. Fixed a bug in WebGUI::Utility::isInSubnet where Net::Subnets->check needs a scalar. Modified t/User.t to use addresses in CIDR format.
This commit is contained in:
parent
c6bc09f79c
commit
cd6759f311
7 changed files with 55 additions and 26 deletions
4
t/User.t
4
t/User.t
|
|
@ -231,9 +231,9 @@ ok ($admin->isInGroup($cm->getId), "Admin is not member of group");
|
|||
|
||||
my $origFilter = $cm->ipFilter;
|
||||
|
||||
$cm->ipFilter('192.168.0.');
|
||||
$cm->ipFilter('192.168.0.0/24');
|
||||
|
||||
is( $cm->ipFilter, "192.168.0.", "ipFilter assignment to local net, 192.168.0.");
|
||||
is( $cm->ipFilter, "192.168.0.0/24", "ipFilter assignment to local net, 192.168.0.0/24");
|
||||
|
||||
ok ($visitor->isInGroup($cm->getId), "Visitor is allowed in via IP");
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue