Some code cleanup
This commit is contained in:
parent
01d2322af6
commit
cd8f7a1f30
5 changed files with 25 additions and 465 deletions
|
|
@ -1,22 +1,11 @@
|
|||
var myCompareTable;
|
||||
|
||||
YAHOO.util.Event.addListener(window, "load", function() {
|
||||
YAHOO.example.XHR_JSON = new function() {
|
||||
this.formatUrl = function(elCell, oRecord, oColumn, sData) {
|
||||
elCell.innerHTML = "<a href='" + oRecord.getData("url") + "' target='_blank'>" + sData + "</a>";
|
||||
};
|
||||
|
||||
this.formatCheckBox = function(elCell, oRecord, oColumn, sData) {
|
||||
var innerHTML = "<input type='checkbox' name='listingId' value='" + sData + "' id='" + sData + "_checkBox'";
|
||||
if(typeof(oRecord.getData("checked")) != 'undefined'){
|
||||
innerHTML = innerHTML + " checked='checked'";
|
||||
}
|
||||
innerHTML = innerHTML + ">";
|
||||
elCell.innerHTML = innerHTML;
|
||||
};
|
||||
|
||||
var myColumnDefs = [
|
||||
{key:"checkBox",label:"",sortable:false},//,formatter:this.formatCheckBox
|
||||
{key:"checkBox",label:"",sortable:false},
|
||||
{key:"title", label:"Name", sortable:true, formatter:this.formatUrl},
|
||||
{key:"views", sortable:true, sortOptions:{defaultDir:YAHOO.widget.DataTable.CLASS_DESC}},
|
||||
{key:"clicks", sortable:true, sortOptions:{defaultDir:YAHOO.widget.DataTable.CLASS_DESC}},
|
||||
|
|
@ -42,13 +31,11 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
this.myDataTable = new YAHOO.widget.DataTable("compareForm", myColumnDefs,
|
||||
this.myDataSource, {initialRequest:uri});
|
||||
|
||||
//var oColumn = this.myDataTable.getColumn(3);
|
||||
this.myDataTable.hideColumn(this.myDataTable.getColumn(2));
|
||||
this.myDataTable.hideColumn(this.myDataTable.getColumn(3));
|
||||
this.myDataTable.hideColumn(this.myDataTable.getColumn(4));
|
||||
this.myDataTable.hideColumn(this.myDataTable.getColumn(5));
|
||||
|
||||
|
||||
var btnSortByViews = new YAHOO.widget.Button("sortByViews");
|
||||
btnSortByViews.on("click", function(e) {
|
||||
this.myDataTable.sortColumn(this.myDataTable.getColumn(2));
|
||||
|
|
@ -73,18 +60,9 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
this.set("sortedBy", null);
|
||||
this.onDataReturnAppendRows.apply(this,arguments);
|
||||
};
|
||||
|
||||
|
||||
|
||||
//var compareCheckBoxes = YAHOO.util.Dom.getElementsByClassName('compareCheckBox');
|
||||
//for (var i = compareCheckBoxes.length; i--; ) {
|
||||
// alert('bla');
|
||||
// compareCheckBoxes[i].onchange = compareFormButton;
|
||||
//}
|
||||
|
||||
var btnCompare = new YAHOO.widget.Button("compare",{disabled:true,id:"compareButton"});
|
||||
btnCompare.on("click", function(e) {
|
||||
alert('bla');
|
||||
window.document.forms['doCompare'].submit();
|
||||
},this,true);
|
||||
|
||||
|
|
@ -105,38 +83,3 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
};
|
||||
});
|
||||
|
||||
// function compareFormButton () {
|
||||
// var compareCheckBoxes = YAHOO.util.Dom.getElementsByClassName('compareCheckBox','input');
|
||||
//alert(compareCheckBoxes.length);
|
||||
// var checked = 0;
|
||||
// for (var i = compareCheckBoxes.length; i--; ) {
|
||||
// if(compareCheckBoxes[i].checked){
|
||||
// checked++;
|
||||
// }
|
||||
// }
|
||||
//alert(checked);
|
||||
// }
|
||||
|
||||
//function sort() {
|
||||
// myCompareTable.sortColumn()
|
||||
// var oColumn = myCompareTable.getColumn(3);
|
||||
// myCompareTable.hideColumn(oColumn);
|
||||
//}
|
||||
|
||||
function bla() {
|
||||
var callback1 = {
|
||||
success : myCallback,
|
||||
failure : myCallback,
|
||||
scope : this.myDataTable
|
||||
};
|
||||
this.myDataSource.sendRequest("func=getCompareFormData",
|
||||
callback1);
|
||||
|
||||
var callback2 = {
|
||||
success : myCallback,
|
||||
failure : myCallback,
|
||||
scope : this.myDataTable
|
||||
};
|
||||
this.myDataSource.sendRequest("func=getCompareFormData",
|
||||
callback2);
|
||||
}
|
||||
|
|
@ -1,5 +1,3 @@
|
|||
//var myCompareTable;
|
||||
|
||||
YAHOO.util.Event.addListener(window, "load", function() {
|
||||
YAHOO.example.XHR_JSON = new function() {
|
||||
var Dom = YAHOO.util.Dom;
|
||||
|
|
@ -30,7 +28,7 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
this.myDataSource.connXhrMode = "queueRequests";
|
||||
this.myDataSource.responseSchema = {
|
||||
resultsList: "ResultSet.Result",
|
||||
fields: columnKeys //["name","AwioUvaZXmAEaFw20tx3Q","CWNjAHcmh0pEF6WJooomJA"]
|
||||
fields: columnKeys
|
||||
};
|
||||
|
||||
var uri = "func=getCompareListData";
|
||||
|
|
@ -41,16 +39,6 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
var myDataTable = new YAHOO.widget.DataTable("compareList", myColumnDefs,
|
||||
this.myDataSource, {initialRequest:uri});
|
||||
|
||||
//var oColumn = this.myDataTable.getColumn(3);
|
||||
//this.myDataTable.hideColumn(oColumn);
|
||||
|
||||
|
||||
//var btnAddRows = new YAHOO.widget.Button("hidecolumn");
|
||||
//btnAddRows.on("click", function(e) {
|
||||
|
||||
//var oColumn = this.myDataTable.getColumn(3);
|
||||
// this.myDataTable.sortColumn(oColumn);
|
||||
//},this,true);
|
||||
|
||||
this.myDataSource.doBeforeParseData = function (oRequest, oFullResponse) {
|
||||
myDataTable.getRecordSet().reset();
|
||||
|
|
@ -79,11 +67,8 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
};
|
||||
|
||||
var myCallback2 = function() {
|
||||
//this.getRecordSet().reset();
|
||||
this.set("sortedBy", null);
|
||||
this.set("sortedBy", null);
|
||||
this.onDataReturnAppendRows.apply(this,arguments);
|
||||
|
||||
//this.getRecordSet().reset();
|
||||
};
|
||||
|
||||
|
||||
|
|
@ -107,8 +92,6 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
this.myDataSource.sendRequest(uri,callback2);
|
||||
},this,true);
|
||||
|
||||
//btnCompare.set("disabled",true);
|
||||
//alert(btnCompare.get("disabled"));
|
||||
window.compareFormButton = function() {
|
||||
var compareCheckBoxes = YAHOO.util.Dom.getElementsByClassName('compareCheckBox','input');
|
||||
var checked = 0;
|
||||
|
|
@ -117,7 +100,6 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
checked++;
|
||||
}
|
||||
}
|
||||
//alert(maxComparisons);
|
||||
if (checked > 1 && checked < maxComparisons){
|
||||
btnCompare.set("disabled",false);
|
||||
}else{
|
||||
|
|
@ -151,23 +133,8 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
}
|
||||
hideStickies = 0;
|
||||
}
|
||||
|
||||
// var elements = Dom.getElementsByClassName('yui-dt-even yui-dt-first', 'tr');
|
||||
// for(i=0; i<elements.length; i++){
|
||||
// alert(elements[i].id);
|
||||
// Dom.setStyle(elements[i], "display", "none");
|
||||
// Dom.addClass(elements[i],'hidden')
|
||||
// alert(elements[i].className);
|
||||
// var show = true;
|
||||
|
||||
|
||||
// }
|
||||
},this,true);
|
||||
|
||||
//var hideEl = new Dom.get('yui-dt0-bdrow0');
|
||||
//alert(hideEl.id);
|
||||
//Dom.addClass(hideEl,'hidden');
|
||||
|
||||
};
|
||||
});
|
||||
|
||||
|
|
|
|||
|
|
@ -1,6 +1,3 @@
|
|||
//var myCompareTable;
|
||||
//var search;
|
||||
|
||||
YAHOO.util.Event.addListener(window, "load", function() {
|
||||
YAHOO.example.XHR_JSON = new function() {
|
||||
var Dom = YAHOO.util.Dom;
|
||||
|
|
@ -9,19 +6,8 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
elCell.innerHTML = "<a href='" + oRecord.getData("url") + "' target='_blank'>" + sData + "</a>";
|
||||
};
|
||||
|
||||
this.formatCheckBox = function(elCell, oRecord, oColumn, sData) {
|
||||
var innerHTML = "<input type='checkbox' name='listingId' value='" + sData + "' id='" + sData + "_checkBox'";
|
||||
if(typeof(oRecord.getData("checked")) != 'undefined'){
|
||||
if(oRecord.getData("checked") == 'checked'){
|
||||
innerHTML = innerHTML + " checked='checked'";
|
||||
}
|
||||
}
|
||||
innerHTML = innerHTML + ">";
|
||||
elCell.innerHTML = innerHTML;
|
||||
};
|
||||
|
||||
var myColumnDefs = [
|
||||
{key:"checkBox",label:""},//,sortable:false,formatter:this.formatCheckBox
|
||||
{key:"checkBox",label:""},
|
||||
{key:"title", label:"Name", sortable:true, formatter:this.formatUrl},
|
||||
{key:"views", sortable:true},
|
||||
{key:"clicks", sortable:true},
|
||||
|
|
@ -29,10 +15,10 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
];
|
||||
|
||||
var uri = "func=getCompareFormData";
|
||||
if(typeof(listingIds) != 'undefined'){
|
||||
for (var i = 0; i < listingIds.length; i++) {
|
||||
uri = uri+';listingId='+listingIds[i];
|
||||
}
|
||||
if(typeof(listingIds) != 'undefined'){
|
||||
for (var i = 0; i < listingIds.length; i++) {
|
||||
uri = uri+';listingId='+listingIds[i];
|
||||
}
|
||||
}
|
||||
|
||||
this.myDataSource = new YAHOO.util.DataSource("?");
|
||||
|
|
@ -43,21 +29,15 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
fields: ["title","views","clicks","compares","checkBox","checked","url"]
|
||||
};
|
||||
|
||||
|
||||
var myDataTable = new YAHOO.widget.DataTable("compareForm", myColumnDefs,
|
||||
this.myDataSource, {initialRequest:uri});
|
||||
|
||||
this.myDataSource.doBeforeParseData = function (oRequest, oFullResponse) {
|
||||
|
||||
myDataTable.getRecordSet().reset();
|
||||
return oFullResponse;
|
||||
}
|
||||
var myDataSource = this.myDataSource;
|
||||
|
||||
//var oColumn = myDataTable.getColumn(3);
|
||||
//myDataTable.hideColumn(oColumn);
|
||||
|
||||
|
||||
var myCallback = function() {
|
||||
myDataTable.getRecordSet().reset();
|
||||
this.set("sortedBy", null);
|
||||
|
|
@ -108,15 +88,12 @@ YAHOO.util.Event.addListener(window, "load", function() {
|
|||
checked++;
|
||||
}
|
||||
}
|
||||
alert(checked);
|
||||
if (checked > 1 && checked < maxComparisons){
|
||||
btnCompare.set("disabled",false);
|
||||
}else{
|
||||
btnCompare.set("disabled",true);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
};
|
||||
});
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue