oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Take advantage of CartItem's getShippingAddress method to guarantee that we always get the right address object.

Browse source
This commit is contained in:
Colin Kuskie 2010-09-22 14:47:48 -07:00
parent c9c62eff84
commit cebec958d9
1 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

13
lib/WebGUI/Shop/Tax.pm
View file

@ -102,24 +102,15 @@ sub calculate {
unless ref($cart) eq 'WebGUI::Shop::Cart';
my $book = $cart->getAddressBook;
# Fetch the default shipping address for each item in the cart that hasn't set its own.
my $shippingAddress = $book->getAddress( $cart->get('shippingAddressId') ) if $cart->get('shippingAddressId');
my $driver = $self->getDriver;
my $tax = 0;
foreach my $item (@{ $cart->getItems }) {
my $sku = $item->getSku;
my $quantity = $item->get('quantity');
my $quantity = $item->quantity;
my $unitPrice = $sku->getPrice;
# Check if this cart item overrides the shipping address. If it doesn't, use the default shipping address.
my $itemAddress = $shippingAddress;
if (defined $item->get('shippingAddressId')) {
$itemAddress = $book->getAddress($item->get('shippingAddressId'));
}
my $taxRate = $driver->getTaxRate( $sku, $itemAddress );
my $taxRate = $driver->getTaxRate( $sku, $item->getShippingAddress );
# Calc the monetary tax for the given quantity of this item and add it to the total.
$tax += $unitPrice * $quantity * $taxRate / 100;