oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change the YesNo form plugin to be a subclass of RadioList. Fix rendering problems with RadioList. Fixes bug #11777

Browse source
This commit is contained in:
Colin Kuskie 2010-08-16 11:11:30 -07:00
parent 7c3d572146
commit decfa808bb
4 changed files with 40 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/WebGUI/Form/List.pm
View file

@ -52,7 +52,7 @@ sub alignmentSeparator {
return "<br />\n";
}
else {
return " &nbsp; &nbsp;\n";
return "&nbsp;&nbsp;";
}
}

13
lib/WebGUI/Form/RadioList.pm
View file

@ -141,13 +141,14 @@ sub toHtml {
$checked = 1;
}
$output .= WebGUI::Form::Radio->new($self->session, {
name=>$self->get('name'),
value=>$key,
extras=>$self->get('extras'),
checked=>$checked,
id=>$self->get('name').$i
name => $self->get('name'),
value => $key,
extras => $self->get('extras'),
checked => $checked,
id => $self->get('name').$i,
label => $options->{$key},
})->toHtml;
$output .= '<label for="'.$self->get('name').$i.'">'.$options->{$key}."</label>" . $alignment;
$output .= $alignment;
}
$output .= "</fieldset>";
return $output;

72
lib/WebGUI/Form/YesNo.pm
View file

@ -15,8 +15,7 @@ package WebGUI::Form::YesNo;
=cut
use strict;
use base 'WebGUI::Form::Control';
use WebGUI::Form::Radio;
use base 'WebGUI::Form::RadioList';
use WebGUI::International;
=head1 NAME
@ -39,6 +38,18 @@ The following methods are specifically available from this class. Check the supe
#-------------------------------------------------------------------
=head2 areOptionsSettable ( )
Options are predefined for a Yes/No.
=cut
sub areOptionsSettable {
return 0;
}
#-------------------------------------------------------------------
=head2 definition ( [ additionalTerms ] )
See the super class for additional details.
@ -92,6 +103,24 @@ sub getName {
#-------------------------------------------------------------------
=head2 getOptions
Return the options, set to defaults for the Yes/No. These options are not overridable.
=cut
sub getOptions {
my $self = shift;
my $i18n = WebGUI::International->new($self->session);
$self->set('options',{
1 => $i18n->get(138),
0 => $i18n->get(139),
});
return $self->SUPER::getOptions;
}
#-------------------------------------------------------------------
=head2 getValue ( [ value ] )
If value is present, we will process it, otherwise the superclass will handle the request.
@ -137,44 +166,5 @@ sub isDynamicCompatible {
return 1;
}
#-------------------------------------------------------------------
=head2 toHtml ( )
Renders a yes/no question field.
=cut
sub toHtml {
my $self = shift;
my $i18n = WebGUI::International->new($self->session);
my ($checkYes, $checkNo);
if ($self->getOriginalValue) {
$checkYes = 1;
} else {
$checkNo = 1;
}
my $output = '<fieldset style="border:none;margin:0;padding:0">'
. WebGUI::Form::Radio->new($self->session,
checked => $checkYes,
name => $self->get("name"),
value => 1,
extras => $self->get("extras"),
label => $i18n->get(138),
)->toHtml
. '&nbsp;&nbsp;&nbsp;'
. WebGUI::Form::Radio->new($self->session,
checked => $checkNo,
name => $self->get("name"),
value => 0,
extras => $self->get("extras"),
label => $i18n->get(139),
)->toHtml
. '</fieldset>'
;
return $output;
}
1;