diff --git a/www/extras/colorpicker/colorpicker.js b/www/extras/colorpicker/colorpicker.js index 0679c189d..86bc02676 100644 --- a/www/extras/colorpicker/colorpicker.js +++ b/www/extras/colorpicker/colorpicker.js @@ -58,30 +58,20 @@ WebguiColorPicker = function() { return { init: function () { - var ddPicker = document.createElement('div'); - ddPicker.id = "ddPicker"; - ddPicker.style.display = "none"; - document.body.appendChild(ddPicker); - }, - - setColor: function () { - var color = "#"+document.getElementById("hexval").value; - currentColorField.value = color; - currentColorField.onchange(); - ddPicker = Dom.get("ddPicker"); - ddPicker.innerHTML = ""; - ddPicker.style.display = "none"; - + var thepicker = document.createElement('div'); + thepicker.id = "ddPicker"; + thepicker.style.display = "none"; + document.body.appendChild(thepicker); }, display: function (field) { - currentColorField = document.getElementById(field); + currentColorField = Dom.get(field); var extras = getWebguiProperty("extrasURL"); - ddPicker = Dom.get("ddPicker"); - ddPicker.style.top = YAHOO.util.Dom.getY(currentColorField) + "px"; - ddPicker.style.left = YAHOO.util.Dom.getX(currentColorField) + "px"; - ddPicker.style.display = "block"; - ddPicker.innerHTML = '
 

R H
G S
B V

#
 
'; + thepicker = Dom.get("ddPicker"); + thepicker.style.top = YAHOO.util.Dom.getY(currentColorField) + "px"; + thepicker.style.left = YAHOO.util.Dom.getX(currentColorField) + "px"; + thepicker.style.display = "block"; + thepicker.innerHTML = '
 

R H
G S
B V

#
 
'; hue = Slider.getVertSlider("hueBg", "hueThumb", 0, pickerSize); hue.subscribe("change", hueUpdate); @@ -96,9 +86,17 @@ WebguiColorPicker = function() { color = color.substring(1,7); var hsv = Color.hex2hsv(color); hue.setValue(pickerSize - Math.round((hsv["h"] * pickerSize)/360)); - //picker.setRegionValue(hsv["s"] * pickerSize, pickerSize - Math.round(hsv["v"]*100/pickerSize) ); picker.setRegionValue(hsv["s"] * pickerSize, pickerSize - Math.round(hsv["v"]*128/pickerSize) +1); Dom.get("hexval").value = color; + }, + + setColor: function () { + var color = "#"+document.getElementById("hexval").value; + currentColorField.value = color; + currentColorField.onchange(); + thepicker = Dom.get("ddPicker"); + thepicker.innerHTML = ""; + thepicker.style.display = "none"; } } }(); diff --git a/www/extras/colorpicker/example.html b/www/extras/colorpicker/example.html index 281f39d93..3b15e3235 100644 --- a/www/extras/colorpicker/example.html +++ b/www/extras/colorpicker/example.html @@ -23,14 +23,11 @@ return props[propName]; -
- +
-