oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add a few more tests to hit coverage. Check for non-numeric package IDs.

Browse source
This commit is contained in:
Colin Kuskie 2009-11-07 12:56:43 -08:00
parent bfc05ddc7a
commit e647c013b9
2 changed files with 93 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/WebGUI/Shop/ShipDriver/USPSInternational.pm
View file

@ -192,7 +192,7 @@ sub _calculateFromXML {
foreach my $package (@{ $xmlData->{IntlRateResponse}->{Package} }) {
my $id = $package->{ID};
##Error check for invalid index
if ($id < 0 || $id > $#shippableUnits) {
if ($id < 0 || $id > $#shippableUnits || $id !~ /^\d+$/) {
WebGUI::Error::Shop::RemoteShippingRate->throw(error => "Illegal package index returned by USPS: $id");
}
if (exists $package->{Error}) {