oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move all user lookups in www_listUsers to statement handles.

Browse source
This commit is contained in:
Colin Kuskie 2011-12-28 18:19:05 -08:00
parent 3e5b18b8b4
commit e65989b114
1 changed files with 32 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

59
lib/WebGUI/Operation/User.pm
View file

@ -1090,6 +1090,29 @@ sub www_listUsers {
<td class="tableHeader">'.$i18n->get( "time recorded" ).'</td>
</tr>';
my $p = doUserSearch($session,"listUsers",1);
my $user_loginlog = $session->db->prepare(
q{
select status, timeStamp, lastPageViewed, sessionId
from userLoginLog
where userId = ?
order by timeStamp desc
limit 1
},
);
my $last_page_view = $session->db->prepare(
q{
select lastPageView
from userSession
where sessionId = ?
},
);
my $total_time = $session->db->prepare(
q{
select sum(lastPageViewed - timeStamp)
from userLoginLog
where userId = ?
},
);
foreach my $data (@{$p->getPageData}) {
$output .= '<tr class="tableData">';
$output .= '<td>'.$status{$data->{status}}.'</td>';
@ -1099,26 +1122,11 @@ sub www_listUsers {
$output .= '<td class="tableData">'.$session->datetime->epochToHuman($data->{dateCreated},"%z").'</td>';
$output .= '<td class="tableData">'.$session->datetime->epochToHuman($data->{lastUpdated},"%z").'</td>';
my ( $status, $lastLogin, $lastView, $lastSession )
= $session->db->quickArray(
q{
select status, timeStamp, lastPageViewed, sessionId
from userLoginLog
where userId = ?
order by timeStamp desc
limit 1
},
[ $data->{userId} ]
);
$user_loginlog->execute([$data->{userId}]);
my ( $status, $lastLogin, $lastView, $lastSession ) = $user_loginlog->fetchrow_array;
my $trueLastView = $session->db->quickScalar(
q{
select lastPageView
from userSession
where sessionId = ?
},
[ $lastSession ]
);
$last_page_view->execute([$lastSession]);
my ($trueLastView) = $last_page_view->fetchrow_array();
# format last page view, preferring session recorded view time
$lastView = $trueLastView || $lastView;
@ -1126,14 +1134,8 @@ sub www_listUsers {
$lastLogin &&= $session->datetime->epochToHuman($lastLogin);
my $totalTime = $session->db->quickScalar(
q{
select sum(lastPageViewed - timeStamp)
from userLoginLog
where userId = ?
},
[$data->{userId}]
);
$total_time->execute([$data->{userId}]);
my ($totalTime) = $total_time->fetchrow_array();
if ($totalTime) {
my ($interval, $units)
@ -1151,6 +1153,9 @@ sub www_listUsers {
$output .= '</table>';
$p->setAlphabeticalKey('username');
$output .= $p->getBarTraditional;
$user_loginlog->finish;
$last_page_view->finish;
$total_time->finish;
my $submenu = _submenu(
$session,
{ workarea => $output, }