oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove duplicate code in addUsers, add more tests to Group.t to cover

Browse source
This commit is contained in:
Colin Kuskie 2007-03-07 00:16:22 +00:00
parent b24bd78e8d
commit ec3eebda9b
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/WebGUI/Group.pm
View file

@ -163,7 +163,6 @@ sub addUsers {
$self->clearCaches();
my $expireOffset = shift || $self->get("expireOffset");
foreach my $uid (@{$users}) {
next if ($uid eq '1' and !isIn($self->getId, 1, 7));
my ($isIn) = $self->session->db->quickArray("select count(*) from groupings where groupId=? and userId=?", [$self->getId, $uid]);
unless ($isIn) {
$self->session->db->write("insert into groupings (groupId,userId,expireDate) values (?,?,?)", [$self->getId, $uid, ($self->session->datetime->time()+$expireOffset)]);