oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

A few more tests to kick coverage up to 100 on WebGUI::Session::Setting

Browse source 
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
	getRefererUrl returned parameters and accepted weird methods that
	looked like http but weren't.
This commit is contained in:
Colin Kuskie 2006-09-25 03:49:25 +00:00
parent 00e37ae971
commit eea7b941c9
4 changed files with 60 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/WebGUI/Session/Setting.pm
View file

@ -67,7 +67,7 @@ sub add {
my $name = shift;
my $value = shift;
$self->{_settings}{$name} = $value;
$self->session->db->write("insert into settings (name,value) values (".$self->session->db->quote($name).",".$self->session->db->quote($value).")");
$self->session->db->write("insert into settings (name,value) values (?,?)",[$name, $value]);
}
#-------------------------------------------------------------------
@ -136,7 +136,7 @@ sub remove {
my $self = shift;
my $name = shift;
delete $self->{_settings}{$name};
$self->session->db->write("delete from settings where name=".$self->session->db->quote($name));
$self->session->db->write("delete from settings where name=?",[$name]);
}
@ -175,7 +175,7 @@ sub set {
my $name = shift;
my $value = shift;
$self->{_settings}{$name} = $value;
$self->session->db->write("update settings set value=".$self->session->db->quote($value)." where name=".$self->session->db->quote($name));
$self->session->db->write("update settings set value=? where name=?",[$value, $name]);
}

4
lib/WebGUI/Session/Url.pm
View file

@ -189,8 +189,8 @@ sub getRefererUrl {
return undef unless ($referer);
my $url = $referer;
my $gateway = $self->session->config->get("gateway");
$url =~ s/htt\w+\:\/\/[A-Za-z0-9\.\-]+$gateway\/*(\S*)/$1/;;
if ($url eq $referer) {
$url =~ s{https?://[A-Za-z0-9\.-]+$gateway/*([^?]*)\??.*$}{$1};
if ($url eq $referer) { ##s/// failed
return undef;
} else {
return $url;