From ef3cbf330311b56578dd53ed3b6b1415e2005dac Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Sun, 28 Nov 2010 19:40:43 -0800 Subject: [PATCH] Add short circuiting to deleteField method in FormBuilder. --- lib/WebGUI/FormBuilder/Role/HasFields.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/WebGUI/FormBuilder/Role/HasFields.pm b/lib/WebGUI/FormBuilder/Role/HasFields.pm index 1503f7cd7..458f540ec 100644 --- a/lib/WebGUI/FormBuilder/Role/HasFields.pm +++ b/lib/WebGUI/FormBuilder/Role/HasFields.pm @@ -82,10 +82,11 @@ Delete a field by name. Returns the field deleted. sub deleteField { my ( $self, $name ) = @_; my $field = delete $self->{_fieldsByName}{$name}; - for ( my $i = 0; $i < scalar @{$self->fields}; $i++ ) { + FIELD: for ( my $i = 0; $i < scalar @{$self->fields}; $i++ ) { my $testField = $self->fields->[$i]; if ( $testField->get('name') eq $name ) { splice @{$self->fields}, $i, 1; + last FIELD; } } return $field;