oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix a bug in the Keyword package where it would return a list of all assetIds with keywords if a reference asset with no keywords was passed in

Browse source
This commit is contained in:
Colin Kuskie 2008-07-18 21:16:59 +00:00
parent 6f90867d26
commit eff71d9c44
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
docs/changelog/7.x.x.txt
View file

@ -25,6 +25,7 @@
perlmonkey2) perlmonkey2)
- fixed: Thing list drop down broken when multiple thingy's on one page. - fixed: Thing list drop down broken when multiple thingy's on one page.
- fixed: Shop Tax pagination and sorting now work. - fixed: Shop Tax pagination and sorting now work.
- fixed: Keywords and SKU assets
7.5.16 7.5.16
- Created a migration from 7.4.40 directly to 7.5.16. - Created a migration from 7.4.40 directly to 7.5.16.

4
lib/WebGUI/Keyword.pm
View file

@ -183,6 +183,7 @@ An array reference of keywords to match.
=head3 matchAssetKeywords =head3 matchAssetKeywords
A reference to an asset that has a list of keywords to match. This can help locate assets that are similar to another asset. A reference to an asset that has a list of keywords to match. This can help locate assets that are similar to another asset.
If the referenced asset does not have any keywords, then an empty array reference is returned.
=head3 isa =head3 isa
@ -213,6 +214,7 @@ sub getMatchingAssets {
asset => $options->{matchAssetKeywords}, asset => $options->{matchAssetKeywords},
asArrayRef => 1, asArrayRef => 1,
}); });
return [] unless scalar @{ $options->{keywords} };
} }
# looking for a class name match # looking for a class name match
@ -240,7 +242,7 @@ sub getMatchingAssets {
# write the query # write the query
my $query = 'select distinct assetKeyword.assetId from assetKeyword left join asset using (assetId) my $query = 'select distinct assetKeyword.assetId from assetKeyword left join asset using (assetId)
where '.join(' and ', @clauses).' order by creationDate desc'; where '.join(' and ', @clauses).' order by creationDate desc';
# perform the search # perform the search
if ($options->{usePaginator}) { if ($options->{usePaginator}) {
my $p = WebGUI::Paginator->new($self->session); my $p = WebGUI::Paginator->new($self->session);