From f25e3948feb2e4d409960930c53de0543f986dbb Mon Sep 17 00:00:00 2001 From: Colin Kuskie Date: Wed, 11 Jul 2012 14:35:02 -0700 Subject: [PATCH] These secondary canView checks are not needed, since the whole thing is guarded by the canView at the top of www_manageRevisions. --- lib/WebGUI/Operation/VersionTag.pm | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/WebGUI/Operation/VersionTag.pm b/lib/WebGUI/Operation/VersionTag.pm index 8a16536e0..254f6dcb0 100644 --- a/lib/WebGUI/Operation/VersionTag.pm +++ b/lib/WebGUI/Operation/VersionTag.pm @@ -613,8 +613,8 @@ sub www_manageVersions { my $i18n = WebGUI::International->new($session,"VersionTag"); my ($icon, $url, $datetime, $user) = $session->quick(qw(icon url datetime user)); $ac->addSubmenuItem($url->page('op=editVersionTag'), $i18n->get("add a version tag")); - $ac->addSubmenuItem($url->page('op=managePendingVersions'), $i18n->get("manage pending versions")) if canView($session); - $ac->addSubmenuItem($url->page('op=manageCommittedVersions'), $i18n->get("manage committed versions")) if canView($session); + $ac->addSubmenuItem($url->page('op=managePendingVersions'), $i18n->get("manage pending versions")); + $ac->addSubmenuItem($url->page('op=manageCommittedVersions'), $i18n->get("manage committed versions")); my ($tag,$workingTagId) = $session->db->quickArray("select name,tagId from assetVersionTag where tagId=?",[$session->scratch->get("versionTag")]); $tag ||= "None"; my $rollback = $i18n->get("rollback"); @@ -630,9 +630,7 @@ sub www_manageVersions { my $u = WebGUI::User->new($session,$tag->get("createdBy")); $output .= ' '; - if (canView($session)) { - $output .= $icon->delete("op=rollbackVersionTag;tagId=".$tag->getId,undef,$rollbackPrompt); - } + $output .= $icon->delete("op=rollbackVersionTag;tagId=".$tag->getId,undef,$rollbackPrompt); $output .= $icon->edit("op=editVersionTag;tagId=".$tag->getId) .' getId).'">'.$tag->get("name").'