From f4e43c9b31b33d0ec8ca93cf7bceb50f9abe7a55 Mon Sep 17 00:00:00 2001
From: Graham Knop <graham@plainblack.com>
Date: Tue, 19 Aug 2008 17:36:08 +0000
Subject: [PATCH] Only note an upgrade in the DB after it succeeded

This prevents it from bypassing a failed upgrade if the upgrade.pl script is run again.  Instead it will get stuck on the failed upgrade, forcing the problem to be resolved instead of ignored.
---
 docs/upgrades/_upgrade.skeleton | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/upgrades/_upgrade.skeleton b/docs/upgrades/_upgrade.skeleton
index 2ab5a0a24..ccf176626 100644
--- a/docs/upgrades/_upgrade.skeleton
+++ b/docs/upgrades/_upgrade.skeleton
@@ -74,7 +74,6 @@ sub start {
     $session->user({userId=>3});
     my $versionTag = WebGUI::VersionTag->getWorking($session);
     $versionTag->set({name=>"Upgrade to ".$toVersion});
-    $session->db->write("insert into webguiVersion values (".$session->db->quote($toVersion).",'upgrade',".$session->datetime->time().")");
     return $session;
 }
 
@@ -84,6 +83,7 @@ sub finish {
     updateTemplates($session);
     my $versionTag = WebGUI::VersionTag->getWorking($session);
     $versionTag->commit;
+    $session->db->write("insert into webguiVersion values (".$session->db->quote($toVersion).",'upgrade',".$session->datetime->time().")");
     $session->close();
 }