oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Additional tests to cover WebGUI::Session::Scratch.

Browse source 
Found and fixed a but in Session/Scratch/deleteNameByValue.  It would
not delete any value that was false (0, '' or undef).  Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
This commit is contained in:
Colin Kuskie 2006-10-01 21:49:05 +00:00
parent fc11dd64b2
commit f5aaa2e996
2 changed files with 53 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/WebGUI/Session/Scratch.pm
View file

@ -112,7 +112,7 @@ The name of the scratch variable.
=head3 value
The value to match.
The value to match. This can be anything except for undef.
=cut
@ -120,7 +120,7 @@ sub deleteNameByValue {
my $self = shift;
my $name = shift;
my $value = shift;
return undef unless ($name and $value);
return undef unless ($name and defined $value);
delete $self->{_data}{$name} if ($self->{_data}{$name} eq $value);
$self->session->db->write("delete from userSessionScratch where name=? and value=?", [$name,$value]);
}