oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

setHelp not used anymore, clean up tests

Browse source
This commit is contained in:
Graham Knop 2007-09-21 02:30:12 +00:00
parent eaf73a976e
commit f8781fede9
7 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
lib/WebGUI/Asset.pm
View file

@ -2261,7 +2261,6 @@ sub www_changeUrl {
$f->text(name=>"url", value=>$self->get('url'), label=>$i18n->get("104"), hoverHelp=>$i18n->get('104 description')); $f->text(name=>"url", value=>$self->get('url'), label=>$i18n->get("104"), hoverHelp=>$i18n->get('104 description'));
$f->yesNo(name=>"confirm", value=>0, label=>$i18n->get("confirm change"), hoverHelp=>$i18n->get("confirm change url message"), subtext=>'<br />'.$i18n->get("confirm change url message")); $f->yesNo(name=>"confirm", value=>0, label=>$i18n->get("confirm change"), hoverHelp=>$i18n->get("confirm change url message"), subtext=>'<br />'.$i18n->get("confirm change url message"));
$f->submit; $f->submit;
$self->getAdminConsole->setHelp('change url', 'Asset');
return $self->getAdminConsole->render($f->print,$i18n->get("change url")); return $self->getAdminConsole->render($f->print,$i18n->get("change url"));
} }

1
lib/WebGUI/AssetBranch.pm
View file

@ -243,7 +243,6 @@ sub www_editBranch {
); );
} }
} }
$ac->setHelp('edit branch', 'Asset');
return $ac->render($tabform->print, $i18n->get('edit branch','Asset')); return $ac->render($tabform->print, $i18n->get('edit branch','Asset'));
} }

1
lib/WebGUI/AssetClipboard.pm
View file

@ -364,7 +364,6 @@ sub www_manageClipboard {
return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(12)); return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(12));
my $i18n = WebGUI::International->new($self->session, "Asset"); my $i18n = WebGUI::International->new($self->session, "Asset");
my ($header,$limit); my ($header,$limit);
$ac->setHelp("clipboard manage");
if ($self->session->form->process("systemClipboard") && $self->session->user->isInGroup(3)) { if ($self->session->form->process("systemClipboard") && $self->session->user->isInGroup(3)) {
$header = $i18n->get(966); $header = $i18n->get(966);
$ac->addSubmenuItem($self->getUrl('func=manageClipboard'), $i18n->get(949)); $ac->addSubmenuItem($self->getUrl('func=manageClipboard'), $i18n->get(949));

1
lib/WebGUI/AssetExportHtml.pm
View file

@ -307,7 +307,6 @@ Displays the export page administrative interface
sub www_export { sub www_export {
my $self = shift; my $self = shift;
return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(13)); return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(13));
$self->getAdminConsole->setHelp("page export", "Asset");
my $i18n = WebGUI::International->new($self->session, "Asset"); my $i18n = WebGUI::International->new($self->session, "Asset");
my $f = WebGUI::HTMLForm->new($self->session,-action=>$self->getUrl); my $f = WebGUI::HTMLForm->new($self->session,-action=>$self->getUrl);
$f->hidden( $f->hidden(

3
lib/WebGUI/AssetMetaData.pm
View file

@ -273,7 +273,6 @@ sub www_editMetaDataField {
-value=>$fieldInfo->{defaultValue} -value=>$fieldInfo->{defaultValue}
); );
$f->submit(); $f->submit();
$ac->setHelp("metadata edit property","Asset");
return $ac->render($f->print, $i18n->get('Edit Metadata')); return $ac->render($f->print, $i18n->get('Edit Metadata'));
} }
@ -290,7 +289,6 @@ sub www_editMetaDataFieldSave {
my $ac = WebGUI::AdminConsole->new($self->session,"content profiling"); my $ac = WebGUI::AdminConsole->new($self->session,"content profiling");
return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(4)); return $self->session->privilege->insufficient() unless ($self->session->user->isInGroup(4));
my $i18n = WebGUI::International->new($self->session,"Asset"); my $i18n = WebGUI::International->new($self->session,"Asset");
$ac->setHelp("metadata edit property","Asset");
# Check for duplicate field names # Check for duplicate field names
my $fid = $self->session->form->process("fid"); my $fid = $self->session->form->process("fid");
my $fieldName = $self->session->form->process("fieldName"); my $fieldName = $self->session->form->process("fieldName");
@ -342,7 +340,6 @@ sub www_manageMetaData {
$output .= $self->session->icon->edit("func=editMetaDataField;fid=".$fieldId,$self->get("url")); $output .= $self->session->icon->edit("func=editMetaDataField;fid=".$fieldId,$self->get("url"));
$output .= " <b>".$fields->{$fieldId}{fieldName}."</b><br />"; $output .= " <b>".$fields->{$fieldId}{fieldName}."</b><br />";
} }
$ac->setHelp("metadata manage","Asset");
return $ac->render($output); return $ac->render($output);
} }

1
lib/WebGUI/AssetVersioning.pm
View file

@ -525,7 +525,6 @@ sub www_manageRevisions {
} }
$sth->finish; $sth->finish;
$output .= '</table>'; $output .= '</table>';
$ac->setHelp('manage versions','Asset');
return $ac->render($output,$i18n->get("committed versions", "VersionTag").": ".$self->getTitle); return $ac->render($output,$i18n->get("committed versions", "VersionTag").": ".$self->getTitle);
} }

4
t/Help/setHelp.t
View file

@ -44,6 +44,10 @@ find(\&getHelpTopics, $lib);
$numTests = scalar(@helpTopics) $numTests = scalar(@helpTopics)
; ;
if (!$numTests) {
plan skip_all => 'No uses of setHelp to check';
}
plan tests => $numTests; plan tests => $numTests;
my @helpFileSet = WebGUI::Operation::Help::_getHelpFilesList($session); my @helpFileSet = WebGUI::Operation::Help::_getHelpFilesList($session);