From f99f672b06937a9d77147b8fb6bbd35f74239dcd Mon Sep 17 00:00:00 2001 From: Patrick Donelan Date: Sat, 17 Apr 2010 20:52:22 -0400 Subject: [PATCH] Minor refactoring --- TODO | 6 ++++-- lib/WebGUI.pm | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/TODO b/TODO index 70fd1f4e2..b61b64347 100644 --- a/TODO +++ b/TODO @@ -1,8 +1,8 @@ TODO * Deprecate WebGUI::Session::HTTP - replace with WebGUI::Request/Response -* Delete lib/WebGUI/URL and replace with new Middleware(s) * Investigate moving Cookie handling into middleware -* Turn html debug output into a Plack::Middleware::Debug panel +* Replace WebGUI::authen with something equivalent +* Refactor assets to use streaming response DONE * $session->request is now a Plack::Request object @@ -12,6 +12,8 @@ DONE * Streaming response body * Mostly decoupled WebGUI from Log4perl * Exception handling and error doc mapping +* Plack::Middleware::Debug panels +* Replaces all URL Handlers with Middleware NB * Periodically do a big stress-test and check for leaks, mysql overload etc.. diff --git a/lib/WebGUI.pm b/lib/WebGUI.pm index 6cda217eb..548f17d8b 100644 --- a/lib/WebGUI.pm +++ b/lib/WebGUI.pm @@ -76,7 +76,7 @@ sub call { or die 'Missing WebGUI Session - check WebGUI::Middleware::Session'; # Handle the request - handle($session); + $self->handle($session); # Construct the PSGI response my $response = $session->response; @@ -119,7 +119,7 @@ sub call { } sub handle { - my ( $session ) = @_; + my ( $self, $session ) = @_; # uncomment the following to short-circuit contentHandlers (for benchmarking PSGI scaffolding vs. modperl) # $session->output->print("WebGUI PSGI with contentHandlers short-circuited for benchmarking\n");