Fixes #10660 Crud doesn't like 0

This commit is contained in:
Patrick Donelan 2009-07-18 03:03:22 +00:00
parent ca7a93452a
commit f9c917e426
3 changed files with 71 additions and 1 deletions

View file

@ -3,6 +3,7 @@
- fixed #10665: Navigations with old templates still in 7.7.16
- fixed #10662: Manage Clipboard / delete item
- fixed #10637: shelf displays assets it shouldn't
- fixed #10660: Crud doesn't like 0
7.7.15
- fixed #10629: WebGUI::ProfileField create new field bug

View file

@ -169,7 +169,10 @@ sub create {
# add defaults
my $properties = $class->crud_getProperties($session);
foreach my $property (keys %{$properties}) {
$data->{$property} ||= $properties->{$property}{defaultValue};
# set a default value if it's empty or undef (as per L<update>)
if ($data->{$property} eq "") {
$data->{$property} = $properties->{$property}{defaultValue};
}
}
# determine sequence

66
t/Crud/Subclass.t Normal file
View file

@ -0,0 +1,66 @@
package WebGUI::Crud::Subclass;
use strict;
use base 'WebGUI::Crud';
sub crud_definition {
my ($class, $session) = @_;
my $definition = $class->SUPER::crud_definition($session);
$definition->{tableName} = 'crudSubclass';
$definition->{tableKey} = 'crudSubclassId';
$definition->{sequenceKey} = '';
my $properties = $definition->{properties};
$properties->{field1} = {
fieldType => 'integer',
defaultValue => 5,
};
return $definition;
}
#package main;
# vim:syntax=perl
#-------------------------------------------------------------------
# WebGUI is Copyright 2001-2009 Plain Black Corporation.
#-------------------------------------------------------------------
# Please read the legal notices (docs/legal.txt) and the license
# (docs/license.txt) that came with this distribution before using
# this software.
#------------------------------------------------------------------
# http://www.plainblack.com info@plainblack.com
#------------------------------------------------------------------
# Tests a subclass of WebGUI::Crud
use FindBin;
use strict;
use lib "$FindBin::Bin/../lib";
use Test::More;
use WebGUI::Test; # Must use this before any other WebGUI modules
#----------------------------------------------------------------------------
# Init
my $session = WebGUI::Test->session;
#----------------------------------------------------------------------------
# Tests
plan tests => 4; # Increment this number for each test you create
#----------------------------------------------------------------------------
# Create
WebGUI::Crud::Subclass->crud_createTable($session);
my $record1 = WebGUI::Crud::Subclass->create($session, { field1 => 10 });
isa_ok($record1, "WebGUI::Crud", "isa WebGUI::Crud");
is($record1->get('field1'), 10, "got back correct field1 value");
# bug #10660 (zero should not trigger defaultValue)
is(WebGUI::Crud::Subclass->create($session, { field1 => 0 })->get('field1'), 0, 'zero does not trigger default');
is(WebGUI::Crud::Subclass->create($session, { field1 => '' })->get('field1'), 5, '..but empty string intentionally triggers default');
#----------------------------------------------------------------------------
# Cleanup
END {
WebGUI::Crud::Subclass->crud_dropTable($session);
}
#vim:ft=perl