From fb3211aa3cf3d3b56dc6b4e2dda13c30ec8e3b51 Mon Sep 17 00:00:00 2001
From: Colin Kuskie <colink@perldreamer.com>
Date: Tue, 9 Feb 2010 12:06:25 -0800
Subject: [PATCH] IE8 on XP demands that onclick actions return false,
 otherwise it submits the form twice.  Fixes bug #11336.

---
 docs/changelog/7.x.x.txt           |  1 +
 lib/WebGUI/Content/AssetManager.pm | 10 +++++-----
 lib/WebGUI/Session/Icon.pm         |  2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt
index 45a995e60..29d74a54d 100644
--- a/docs/changelog/7.x.x.txt
+++ b/docs/changelog/7.x.x.txt
@@ -6,6 +6,7 @@
  - fixed #11395: i18n LDAP field name in user properties wrong
  - fixed #11396: WebGUI Workflow Cache Error.
  - fixed #11393: Map template variables missing
+ - fixed #11336: Duplicate Version Tag Created.
 
 7.8.11
  - fixed #11362: Unable to checkout with ITransact plugin
diff --git a/lib/WebGUI/Content/AssetManager.pm b/lib/WebGUI/Content/AssetManager.pm
index c23d46149..5b94b66c6 100644
--- a/lib/WebGUI/Content/AssetManager.pm
+++ b/lib/WebGUI/Content/AssetManager.pm
@@ -411,11 +411,11 @@ ENDHTML
 <div id="dataTableContainer">
 </div>
 <p class="actions"> %s 
-<input type="submit" name="action_update" value="%s" onclick="this.form.func.value='setRanks'; this.form.submit();" />
-<input type="submit" name="action_delete" value="%s" onclick="if( confirm('%s')){ this.form.func.value='deleteList'; this.form.submit(); }{ return false; }" />
-<input type="submit" name="action_cut" value="%s" onclick="this.form.func.value='cutList'; this.form.submit();"/>
-<input type="submit" name="action_copy" value="%s"  onclick="this.form.func.value='copyList'; this.form.submit();"/>
-<input type="submit" name="action_duplicate" value="%s"  onclick="this.form.func.value='duplicateList'; this.form.submit();"/>
+<input type="submit" name="action_update" value="%s" onclick="this.form.func.value='setRanks'; this.form.submit(); return false;" />
+<input type="submit" name="action_delete" value="%s" onclick="if( confirm('%s')){ this.form.func.value='deleteList'; this.form.submit(); return false;}{ return false; }" />
+<input type="submit" name="action_cut" value="%s" onclick="this.form.func.value='cutList'; this.form.submit(); return false;"/>
+<input type="submit" name="action_copy" value="%s"  onclick="this.form.func.value='copyList'; this.form.submit(); return false;"/>
+<input type="submit" name="action_duplicate" value="%s"  onclick="this.form.func.value='duplicateList'; this.form.submit(); return false;"/>
 </p>
 </form>
 <div id="pagination">
diff --git a/lib/WebGUI/Session/Icon.pm b/lib/WebGUI/Session/Icon.pm
index ba4fe5ca4..ef8b0415e 100644
--- a/lib/WebGUI/Session/Icon.pm
+++ b/lib/WebGUI/Session/Icon.pm
@@ -166,7 +166,7 @@ sub delete {
         my $pageURL = shift || $self->session->url->getRequestedUrl;
 	my $confirmText = shift; 
 	if($confirmText) {
-		$confirmText = qq| onclick="return confirm('$confirmText')" |;
+		$confirmText = qq| onclick="return confirm('$confirmText');" |;
 	}
 	my $i18n = WebGUI::International->new($self->session,'Icon');
         my $output = '<p class="toolbarIcon" style="display:inline;vertical-align:middle;"><a href="'.$self->session->url->gateway($pageURL,$urlParams).'" '.$confirmText.'>';