oqapi/webgui
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Dropped the need for the 'id' column in the page table

Browse source
This commit is contained in:
Martin Kamerbeek 2004-08-16 22:32:26 +00:00
parent ed94d6bad2
commit fcd2593a9e
3 changed files with 8 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/changelog/6.x.x.txt
View file

@ -50,7 +50,8 @@
- bugfix [ 996170 ] mesage log logId not being passed - bugfix [ 996170 ] mesage log logId not being passed
- Added template variables user.canPost and user.canView in forum_loop to MessageBoard / RFE[864134] (Leendert Bottelberghs) - Added template variables user.canPost and user.canView in forum_loop to MessageBoard / RFE[864134] (Leendert Bottelberghs)
- Made flat thread work like flat thread -> messages sorted by submission date / RFE[995982]. (Leendert Bottelberghs) - Made flat thread work like flat thread -> messages sorted by submission date / RFE[995982]. (Leendert Bottelberghs)
- Upgraded DBIx::Tree::NestedSet to the latest version (0.15) (Martin Kamerbeek /Procolix)
- Eliminated the use for the 'id' column in the page table (Martin Kamerbeek /Procolix)
6.1.1 6.1.1

1
docs/upgrades/upgrade_6.1.1-6.2.0.sql
View file

@ -266,3 +266,4 @@ create table urls (
params text params text
); );
alter table page drop column id;

11
lib/WebGUI/Page.pm
View file

@ -209,15 +209,12 @@ sub add {
$newPageId = WebGUI::Id::generate(); $newPageId = WebGUI::Id::generate();
$self->add_child_to_right( $self->add_child_to_right(
id =>$self->get('pageId'), pageId =>$self->get('pageId'),
pageId =>$newPageId, provided_primary_key => $newPageId,
parentId=>$self->get('pageId'), parentId=>$self->get('pageId'),
depth =>($self->get('depth') + 1), depth =>($self->get('depth') + 1),
); );
# Fixup the 'id' column that has the wrong value.
WebGUI::SQL->write("update page set id=pageId where pageId=".quote($newPageId));
$self->recacheNavigation; $self->recacheNavigation;
return WebGUI::Page->new($newPageId); return WebGUI::Page->new($newPageId);
@ -1341,9 +1338,11 @@ sub new {
table_name => 'page', table_name => 'page',
left_column_name => 'nestedSetLeft', left_column_name => 'nestedSetLeft',
right_column_name => 'nestedSetRight', right_column_name => 'nestedSetRight',
id_name => 'pageId',
dbh => $session{dbh}, dbh => $session{dbh},
no_alter_table => 1, no_alter_table => 1,
no_locking => 1 no_locking => 1,
no_id_creation => 1,
); );
unless (ref($properties)) { unless (ref($properties)) {
$properties = WebGUI::SQL->quickHashRef("select * from page where pageId=".quote($_[1])); $properties = WebGUI::SQL->quickHashRef("select * from page where pageId=".quote($_[1]));