Commit graph

26 commits

Author SHA1 Message Date
Graham Knop
b832deecd1 convert all cleanup methods to addToCleanup 2010-06-10 10:09:53 -05:00
Colin Kuskie
8d85912da7 Commit the initial Survey for the test. 2010-06-05 21:24:17 -07:00
Doug Bell
247c607393 fixes for weaken and iterator 2010-06-01 19:37:53 -05:00
Colin Kuskie
20d0630658 Fix the Survey Edit icon. Fixes bug #11122 2009-10-12 21:42:26 -07:00
Colin Kuskie
1953e71d76 www_loadSurvey has to process its own macros. Fixes bug #11088. 2009-10-05 10:16:46 -07:00
hao
082b04b967 Fixed bug #10982 where survey admin menu options appear twice. Caused by the Survey Asset directly calling its parent getAdminConsole method instead of instantiating a session instance of the method. 2009-09-15 12:02:49 -04:00
Colin Kuskie
838ae00af5 Provide a way for tests to purge assets with all their (hidden and unreachable)
version tags.  Fix Survey.t that was leaking versionTags.
2009-09-01 22:30:07 +00:00
Patrick Donelan
146373937d Fixed two new Survey bugs
* Survey response startDate stored twice
startDate was being stored both in a column in Survey_response and also inside the
serialised responseJSON. Consolidated to column and moved startDate methods to
Survey.pm where they are actually used. Was not causing errors because both copies
were initialised to "now" at response creation time, and then never changed (this is also
why we don't need any repair code to fix existing survey repsonses in the wild).

* Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled
The only time you'd actually want to modify startDate is when you're trying to simulate
response expiry in test code, which is why I found the above bug when I was writing the
missing test suite for ExpireIncompleteSurveyResponses. Along with test suite, added
upgrade code to enable workflow activity and add it  to the Daily Maintenance Tasks
workflow. Also made minor fixes to the workflow activity, such as making sure it uses
the correct isComplete code.
2009-08-07 01:08:39 +00:00
Patrick Donelan
d820d43760 Fixed #10520 - Survey responses get confused if survey structure modified
Survey responses are now revision-aware.
The survey structure gets revisioned automatically as necessary when changes
are made on the Edit Survey screen (as necessary ~~ a response exists
for the current revision)
2009-06-16 06:25:38 +00:00
Patrick Donelan
216a48580a Fixed #9927 Survey - verbatim
Fixed inconsistencies between answer 'comment' and 'verbatim'.
Updated tests.
Made minor changes to reporting methods but they still need some love.
2009-06-03 00:29:29 +00:00
Patrick Donelan
084a0c3105 Fixed naff Survey::takenCount bug, added explicit test for it 2009-06-02 02:42:37 +00:00
Patrick Donelan
d14cf19e9d Added Survey tests for more question types 2009-05-28 07:23:43 +00:00
Patrick Donelan
4d181da7f9 SurveyJSON bug fixes
Fixed bug in SurveyJSON::update to stop it updating questionType when not asked
Fixed unsafe reference bug in SurveyJSON::getMultipleChoiceBundle
Added more Survey Test Suite tests
2009-05-16 07:24:55 +00:00
Patrick Donelan
6815cd76aa Improved handling of Survey restart 2009-05-13 02:10:34 +00:00
Patrick Donelan
79db642219 Refactored Survey for more happy endings
Refactored www_submitQuestions to use utility submitQuestions sub (for ease of testing)
Replaced numeric flags, completedCode etc..
Added restart() and exitUrl() to the Expression Engine
Added more Survey instance tests
2009-05-12 12:36:26 +00:00
Patrick Donelan
9e2cdeca13 Added some tests for Survey visualization 2009-05-11 11:06:55 +00:00
Colin Kuskie
d83f1fd5fc Last batch of User and Group cleanups. 2009-05-01 03:29:32 +00:00
Patrick Donelan
07e03c7b15 Fixed Survey to follow convention that a value of 0 for maxResponsesPerUser
should imply unlimited. Updated tests and docs to match.
2009-03-27 05:12:57 +00:00
Patrick Donelan
b1b033afa5 Added Survey Workflow onSurveyEndWorkflowId
Fixed username bug
2009-03-15 06:34:37 +00:00
Patrick Donelan
34340e56fb Added Survey::surveyJSON_* convenience methods that auto-persist to the db 2009-02-12 01:07:22 +00:00
Patrick Donelan
7128a3d07c More Survey.pm refactoring
Turned getResponseId into a lazy-loading responseId mutator
Added responseIdCookies flag as a workaround for WebGUI::Test::getPage's
lack of cookie support
2009-02-11 09:27:31 +00:00
Patrick Donelan
e139136d08 Made Survey->surveyJSON lazy-load so that you don't have to call
loadSurveyJSON() everywhere.
2009-02-11 09:26:50 +00:00
Patrick Donelan
8d7599d781 Moved Survey.pm's "survey" and "response" properties to private hash
vars and added accessors.

So that you don't end up with mind-bending code that looks like:
$survey->survey->{survey}
2009-02-11 09:26:27 +00:00
Patrick Donelan
d882181fd1 Started refactoring the Survey.pm Wobject class
Refactored www_jumpTo and added tests
Added Params::Validate
Improved docs
Made call to SurveyJSON->createSurveyOrder() unnecessary
Turned ResponseJSON->nextResponse a mutator
2009-02-11 09:25:42 +00:00
Colin Kuskie
356772b722 Build Survey2 tests. Each survey2 module has at least a basic
load test, and the SurveyJSON module has many more tests in
it, testing new, log, newSection, newQuestion, newAnswer and
newObject.
2008-11-28 05:02:38 +00:00
Patrick Donelan
564b4e90d1 Added skeleton Survey2 test file.
Changed debug logging from ERROR level to DEBUG
2008-11-13 22:39:29 +00:00