Commit graph

24 commits

Author SHA1 Message Date
Scott Walters
0422807b32 Revert "group() function Survey::ExpressionEngine that returns 1/0 depending on whether the current user is in a group" -- wrong branch.
This reverts commit eaa29c5f44.

Conflicts:

	docs/changelog/7.x.x.txt
2012-06-19 19:31:50 -04:00
Scott Walters
eaa29c5f44 group() function Survey::ExpressionEngine that returns 1/0 depending on whether the current user is in a group 2012-06-19 16:22:30 -04:00
Patrick Donelan
804dbcfd26 One-line fix for Survey ExpressionEngine bug that took over a day to find.
One of the file-scoped lexicals in ExpressionEngine wasn't being initialised,
which meant that tagged data was being cached across repeated engine runs
(including, would you believe, across modperl page requests).

The fix includes tests.
2009-11-05 21:15:47 -08:00
Patrick Donelan
5899fa4289 Revert "One-line fix for Survey ExpressionEngine bug that took over a day to find."
This reverts commit bcd99945ca.
2009-11-05 22:37:50 -05:00
Patrick Donelan
bcd99945ca One-line fix for Survey ExpressionEngine bug that took over a day to find.
One of the file-scoped lexicals in ExpressionEngine wasn't being initialised,
which meant that tagged data was being cached across repeated engine runs
(including, would you believe, across modperl page requests).

The fix includes tests.
2009-11-05 22:27:47 -05:00
Patrick Donelan
280e902c09 Fixes to Survey reporting and performance improvements
Fix: Survey export simple/transposed results to csv or tab
Fix: loadTempReportTable handling of revisionDates (and documentation)
Fix: returnResponseForReporting handling of mc questions
NYTProf performance improvements
Added some very basic Survey reporting tests
2009-08-23 05:15:32 +00:00
Patrick Donelan
29f20d3889 Fixed bug in Survey::ExpressionEngine - was not using most recent survey
response to resolve external values
2009-07-03 01:39:53 +00:00
Graham Knop
66843db604 string evals are evil 2009-05-29 21:41:52 +00:00
Patrick Donelan
d14cf19e9d Added Survey tests for more question types 2009-05-28 07:23:43 +00:00
Patrick Donelan
a9638ae691 Survey: Let them eat sort 2009-05-19 02:45:26 +00:00
Patrick Donelan
9cbd30c3d8 Refactored Survey test suite diagnostics etc.. 2009-05-17 08:15:59 +00:00
Patrick Donelan
3105b27034 Improved Survey test setup 2009-05-16 09:06:00 +00:00
Patrick Donelan
79db642219 Refactored Survey for more happy endings
Refactored www_submitQuestions to use utility submitQuestions sub (for ease of testing)
Replaced numeric flags, completedCode etc..
Added restart() and exitUrl() to the Expression Engine
Added more Survey instance tests
2009-05-12 12:36:26 +00:00
Patrick Donelan
639a3398f0 Fixed Survey expression validation handling of verbatim values 2009-05-11 08:16:14 +00:00
Patrick Donelan
5d6b4093be Survey Expression Engine validation++
Survey Expression Engine now detects invalid variable names passed to value(), score(), etc..
Also now detects situations where you have jump targets/expressions defined at multiple levels - thus causing precedence rules to kick in (normally this indicates a mistake)
Fixed Survey edit page bug where TextEditor would not move after gotoExpression textarea resize caused items to move
2009-05-10 07:45:14 +00:00
Patrick Donelan
cf98c81461 Fixed Survey's handling of multi-answer questions (e.g. maxAnswers != 1)
Now stores all supplied answers to multi-answer question as arrayref
Variable [[var]] text replacement converts to comma-separated list
Expression Engine's value() returns appropriate value depending on context
Expression Engine's score() does sum of multi-answers, as you would expect
Updated related i18n & hover-help, and tests
Cleaned up survey js somewhat
2009-05-08 08:00:04 +00:00
Patrick Donelan
f3ed30d939 Refactored Survey ExpressionEngine tag() util into tag() setter and tagged() accessor.
Updated i18n to reflect the fact that min/max/step are used for all numeric types, not just slider.

Also updated textCols/Rows i18n.
2009-05-06 05:53:10 +00:00
Patrick Donelan
3dda2b49d4 Survey Branch Expressions now allow you to "tag" data along the way and store
it in the response data structure along with the actual user input. Tag data
can be used in subsequent expressions, in [[tag]] templated text replacement,
and to classify responses in an arbitrary way.

Refactored Survey expression utility subs that lookup values/scores/tags in
external assets.

Fixed bug whereby only highest precedence Survey expression was being evaluated
rather than letting them all run and do their own short-circuiting.
2009-05-04 06:28:05 +00:00
Patrick Donelan
ac1a00b252 Survey Branch Expressions can now test whether a question
has been reached/answered, rather than just testing for the value
of a response
2009-05-04 04:06:40 +00:00
Patrick Donelan
c3ea6d4683 Added Survey back button, with option to turn it on/off, tests, and i18n
Noticed that some Survey tests are broken, will fix tomorrow
2009-04-21 07:12:07 +00:00
Colin Kuskie
1b9fbb5fbd Fix POD syntax error in ExpressionEngine. 2009-04-09 15:12:25 +00:00
Patrick Donelan
aa8379188a Survey branch expressions can now resolve score()s and value()s from
other survey instances.
2009-04-09 04:04:39 +00:00
Patrick Donelan
a7cb9b031d Made Survey ExpressionEngine disabled by default, controlled via config
file enableSurveyExpressionEngine flag
Added branching based on question score and section score total
Added more tests
2009-04-08 08:12:44 +00:00
Patrick Donelan
9ea4f1cd20 Replaced Survey parseGotoExpression with dedicated ExpressionEngine.
Improved gotoExpression validation error reporting
Added lots more tests
2009-04-08 08:12:14 +00:00