Commit graph

8 commits

Author SHA1 Message Date
Patrick Donelan
e4b18757d8 Fixes bug in ExpireIncompleteSurveyResponses
Use a left outer join on userProfileData so that the workflow processes
responses for users that have been deleted
2009-10-20 16:50:00 +11:00
Patrick Donelan
549f9ce650 Fix bugs in ExpireIncompleteSurveyResponses Workflow
Need to join on revisionDate otherwise one email per Survey revision
will be sent. (Added explicit test for this)

Some standard template vars were also missing - username and userId.

(forward-port from webgui-7.7)
2009-09-25 14:13:15 +10:00
Patrick Donelan
808a558ec8 Minor bug fix for ExpireIncompleteSurveyResponses
Removed unnecessary sql clause from ExpireIncompleteSurveyResponses
workflow activity
2009-08-17 10:10:48 +00:00
Patrick Donelan
146373937d Fixed two new Survey bugs
* Survey response startDate stored twice
startDate was being stored both in a column in Survey_response and also inside the
serialised responseJSON. Consolidated to column and moved startDate methods to
Survey.pm where they are actually used. Was not causing errors because both copies
were initialised to "now" at response creation time, and then never changed (this is also
why we don't need any repair code to fix existing survey repsonses in the wild).

* Survey ExpireIncompleteSurveyResponses Workflow Activity not enabled
The only time you'd actually want to modify startDate is when you're trying to simulate
response expiry in test code, which is why I found the above bug when I was writing the
missing test suite for ExpireIncompleteSurveyResponses. Along with test suite, added
upgrade code to enable workflow activity and add it  to the Daily Maintenance Tasks
workflow. Also made minor fixes to the workflow activity, such as making sure it uses
the correct isComplete code.
2009-08-07 01:08:39 +00:00
Colin Kuskie
aa65b6ca22 Fix a common misspelling of the word definition, in POD. 2009-07-10 21:04:41 +00:00
Graham Knop
a7b6754a19 fix i18n usage 2009-03-12 21:50:55 +00:00
Kaleb Murphy
ef548cbfee Time multiplier was set wrong 2009-02-17 14:20:35 +00:00
Kaleb Murphy
9fe2b5328e Added workflow (and email template to WebGUI/) to delete expired surveys and notify users via email. 2009-02-16 23:49:16 +00:00