Commit graph

36 commits

Author SHA1 Message Date
Colin Kuskie
be37f12ab1 Clone stopped working in several tests in 5.14.2. Remove it in favor of Storable::dclone.
Clone handles being passed scalar data, but dclone does not.
2012-10-23 10:00:53 -07:00
Graham Knop
fe1ac66cca remove useless test END blocks 2010-06-10 10:09:45 -05:00
Patrick Donelan
b5186bfbab fixed #10565: Survey: add question doing double-create 2009-06-22 07:08:08 +00:00
Patrick Donelan
cbc308c55a SurveyJSON size reduction/optimization
SurveyJSON was storing a lot of redundant information (every setting on
every single section/question/answer, which, in most cases, will simply
take on the default values). This was bloating the surveyJSON property in
the db, and equally as importantly, slowing down Survey because it had to
do a lot of JSON parsing on the serialised surveyJSON object.

We now factor out and store the current section/question/answer defaults
along with the surveyJSON data itself, which means that we only needs to
store properties that differ from the defaults. This results is a massive
reduction in the size of the serialized surveyJSON stored in the database,
as well as a speed-up in json parsing time.

The compression/uncompression happens transparently to the rest of Survey.
2009-06-19 08:07:18 +00:00
Patrick Donelan
3e5d5804f6 Made Survey tests a little less dependent on multiple choice bundle defaults 2009-06-16 06:25:09 +00:00
Patrick Donelan
3a25e806c6 Survey bug fixes
Fixed bugs in the handling of logical sections,
creating of responses and counting of responses.
Added in a bunch of new tests.
Jslinting of all survye js files
2009-05-23 09:54:03 +00:00
Patrick Donelan
6815cd76aa Improved handling of Survey restart 2009-05-13 02:10:34 +00:00
Graham Knop
1937ef3ab6 fix survey test 2009-04-30 21:30:15 +00:00
Patrick Donelan
99855719d0 Survey bug fixes: Verbatim responses now properly recorded
Added useText option to responseValuesByVariableName so that it can be
used for both branch expressions and [[var]] text substitution correctly
Added extra verbatim handling to [[var]] text substitution
All survey test now pass, except for one involving True/False
multi-chocie bundle, soon to be fixed by updating bundle
2009-04-22 05:16:29 +00:00
Patrick Donelan
c1ac5b9761 Fixed SurveyJSON->questions which was short-changing getGotoTargets 2009-04-02 05:55:23 +00:00
Colin Kuskie
4e2a8bab91 Bump up the version for Clone, since the new version works with
perl 5.10.
Have SurveyJSON use it instead of dclone.
2009-03-30 19:47:27 +00:00
Graham Knop
4b5b4b9cb0 test fix 2009-03-27 02:03:18 +00:00
Kaleb Murphy
569151c4ad Fixing the fix that shouldnt have been fixed. 2009-03-26 23:32:01 +00:00
Kaleb Murphy
9c60e75cf7 Text has changed 2009-03-26 23:27:14 +00:00
Patrick Donelan
5da0379f99 Updated SurveyJSON tests to recognise goto[Expression] on Section and Question 2009-03-11 15:29:04 +11:00
Patrick Donelan
7ec5cab126 Merge branch 'master' into survey
* master: (121 commits)
  Fix a POD typo.
  correct inbox message from user preface
  Fix a typo in the Default gallery view template
  Documentation bug in buildArrayRefOfHashRefs
  changed screenshots in Matrix Listing view to popup
  matrix privileging fixes
  Fix an i18n typo in the Post user defined variables.
  Remove debugging code.
  approval workflow fix
  matrix upgrade and privileging fixes
  fixed: Template parser cannot be set
  forward porting gallery bug fixes
  preparing for 7.7.0 dev
  parser should be a selectbox, not a selectlist.
  labeling survey as beta
  fixeding my borkes to the changelog
  fixed #9852: Users can accept private messages from Visitor, but Visitor cannot send messages
  preparing for 7.6.14 release
  fix AdSpace, Ad tests
  Restore the original properties for the profile category that was modified for test.
  ...

Conflicts:
	docs/gotcha.txt
	docs/upgrades/upgrade_7.6.10-7.6.11.pl
	lib/WebGUI/Asset/Wobject/Survey.pm
	lib/WebGUI/Asset/Wobject/Survey/SurveyJSON.pm
2009-03-11 15:26:07 +11:00
Graham Knop
d7649d3212 survey test fix 2009-03-03 17:07:53 +00:00
Patrick Donelan
821635eb71 Refactored ResponseJSON and SurveyJSON
Added Params::Validate to ResponseJSON.pm
Refactored ResponseJSON constructor and re-ordered params for
consistency
Added new ->session accessor
Updates tests
Removed unnecessary logging methods
Further refactored SurveyJSON, gave private variables underscores,
replaced direct hash access with accessors
2009-02-03 08:31:43 +00:00
Patrick Donelan
d00c8661f3 Made first argument to SurveyJSON contructor $session for consistency
with rest of wg.

Also added Params::Validate validation.
2009-02-03 08:31:07 +00:00
Patrick Donelan
fe32551bca Added totalSections/Questions/Answers helper subs, refactored
getDragDropList to use helper subs, and added extra $address param
documentation.
2009-01-21 03:34:22 +00:00
Patrick Donelan
6d10570fdb Refactored SurveyJSON's new, freeze and addObject for readability 2009-01-20 07:34:55 +00:00
Patrick Donelan
fc3851705a Implemented Survey branching expressions (#9233). Woot! 2008-12-15 10:25:44 +00:00
Colin Kuskie
8ea45fe456 Switch to using dclone from Clone::clone due to bugs under
perl 5.10
2008-12-05 04:21:43 +00:00
Colin Kuskie
ace2c81fca update SurveyJSON test to fix perl 5.10 misleading errors 2008-12-05 03:41:29 +00:00
Colin Kuskie
75da4c46bd Add more tests for coverage.
Interim checkin for debug assistance.
2008-12-05 03:32:47 +00:00
Colin Kuskie
a50c27de67 add POD, fix a few typos.
Add tests for updateQuestionAnswers
2008-12-04 23:35:40 +00:00
Colin Kuskie
75f6497924 Tests for getEditVars, getEditSectionVars and addAnswersToQuestion.
Add POD.
Fix a bug with setting verbatims in addAnswersToQuestion
2008-12-04 22:01:17 +00:00
Colin Kuskie
24fe2e6dc0 Add tests for getQuestionEditVars.
Refactor out the list of valid question types to make testing easier.
2008-12-04 20:47:42 +00:00
Colin Kuskie
0453f47bc1 Tests for getDragDrop and getAnswerEditVars.
More POD.
2008-12-04 20:18:49 +00:00
Colin Kuskie
d370772762 Make copy use safe references.
Add tests for remove, and copy.
2008-12-03 04:41:38 +00:00
Colin Kuskie
f41421058c Add wide character JSON encoding test. 2008-12-03 02:39:35 +00:00
Colin Kuskie
23f8e48f6d Update POD for several methods.
Make getObject clone data for safety and update tests.
Make newObject always alter $address for consistency and update tests.
2008-12-01 17:39:34 +00:00
Colin Kuskie
377126da8c Add more POD to SurveyJSON.
Add some basic tests for getObject, update and remove.
2008-11-30 04:30:40 +00:00
Colin Kuskie
020c882fb6 Test abusing references in getObject.
More insertObject testing.
More POD.
2008-11-29 17:29:00 +00:00
Colin Kuskie
fe33c87f13 Add tests for insertObject, and a helper method for summarizing the SurveyJSON data structure.
Add POD for insertObject.  Note that splicing beyond the end of the array will generate
a warning.
2008-11-29 05:32:14 +00:00
Colin Kuskie
356772b722 Build Survey2 tests. Each survey2 module has at least a basic
load test, and the SurveyJSON module has many more tests in
it, testing new, log, newSection, newQuestion, newAnswer and
newObject.
2008-11-28 05:02:38 +00:00