There are still a few functional tests that need to be written, they're
codified as TODOs.
In Session/Style.pm, in all methods that have a send immediate option
(when sent=1), they no longer send and cache. This prevents duplicate
heag tags from being generated if generateAdditionalHeadTags was
ever called twice.
fixed a bug in userStyle where it would not process data that was false.
process will do this, so I made userStyle do it as well by adding
in a definedness check on $output.
Found a fixed an infinite loop in WebGUI::Style::process
If an asset was requested to be printed who does not have a
printableStyleTemplateId then process would recurse back up the
lineage until it does find an asset with a printableStyleTemplateId.
Eventually, if none is found, it will find the Asset Root, whose
parent is itself, and it will loop forever.
I added code to jump out of the loop if it recurses back to the
assetRoot.
for default processing and for meta tags when cache busting is enabled.
Fixed a bug where the default meta tag Generator did not contain the
WebGUI version.
Added lots of POD to the Style module detailing how meta tags are
handled in various cases.
requested. It used to be 6, but at somepoint in the 6.x cycle it
was changed to be PBtmpl0000000000000132 in the database.
Added tests that verify that it works correctly.
the Session Id. This is by design.
Added a check to Style.pm so that if no params are passed to setLink that
it won't die by trying to deref undef into a hashref.
First set of tests for Session/Style added.
Found and fixed a but in Session/Scratch/deleteNameByValue. It would
not delete any value that was false (0, '' or undef). Added a defined-ness
check to make sure it will delete 0 or '', but undef is still not handled.
Added POD to say that this was the case.
was enabled a noCache param was always added to the URL. In some
cases it would add 2 noCache params.
To fix this, I added a skipPreventProxyCache param to the gateway method,
and page just passes $pairs and $skipPreventProxyCache to gateway.
Added tests to Url.t to test gateway, page, makeAbsolute and urlize
to bring its coverage up to 100%.
Added tests to Stow.t to bring it's coverage up to 100% as well.
Tests for escape, unescape, extras methods. Test code is big enough
that I've added section delimiting comments. This has helped make
the code a lot more readable.
Convert it to use placeholders as well.
More WebGUI::Session::Url tests, and some bug fixes:
getRefererUrl returned parameters and accepted weird methods that
looked like http but weren't.
that a new userSessionId will be created and that the current sessionId (the actual
session object's id) will be set to this new id.
Add several new tests to Session/Var.t Tried hard to exploit the change in
sessionId and haven't found a way, yet.
be fixed later.
Added lots of comments to start and new subs. Changed db methods to
use placeholders. Changed timely data to call time once so that they
all match.
Session/Id.pm: add a method to validate GUIDs, change s/// to tr/// for efficiency.
Session.pm: change open to use new Id.pm validation method
Scratch.t: Change test from ok to is so that it tells you what the failing ID is.
Id.t: Add validation tests in addition to uniqueness tests. Fix the uniqueness test so that it works. Add tests to check the new validation method
User.t: better clean-up at end
Scratch.t: no newlines in test output
Session/Scratch.pm: convert to use placeholders
Ad.pm: Add missing line of POD.
Group.pm: add method to get all users in a group by karma.
User.pm: isInGroup to use getKarmaUsers.
useful when creating the Stow'ed variable.
When you ->get a Stow variable, you get a reference if you've
stowed an array or hash. So when you modify what you got, it
changes the original inside Stow and you don't need to do a ->set.
This wouldn't work for scalars, unless it was a scalar reference.
This also means that if you modify the variable you stowed (and you
stowed a reference) after you stowed it then the stow will change
as well.
