Commit graph

16684 commits

Author SHA1 Message Date
Graham Knop
1f201260ba remove session from WebGUI::SQL 2011-07-05 09:05:36 -05:00
Graham Knop
4959bfc979 remove WebGUI::Config->readAllConfigs 2011-07-05 08:40:13 -05:00
Graham Knop
106d888e97 stop using readAllConfigs in testEnvironment.pl 2011-07-05 08:35:48 -05:00
Graham Knop
c4af0e33df safer asset reading sql and better parameter validation 2011-07-05 08:35:26 -05:00
Graham Knop
6bf9fbb8d9 stop using readAllConfigs in search.pl 2011-07-05 08:34:16 -05:00
Graham Knop
287c26adaa stop using readAllConfigs in spectre 2011-07-05 08:10:39 -05:00
Graham Knop
caf9efc784 move autoflush to better location 2011-07-05 07:39:41 -05:00
Colin Kuskie
e3a4afe5c3 Allow reasonable default dates in ISO 9601 format. Fixes bug #12165. 2011-07-04 14:14:17 -07:00
Colin Kuskie
7e8ae8fe9a Fix spacing issues with WebGUI::DateTime->webguiDate. 2011-07-04 12:15:58 -07:00
Graham Knop
279d0c3d30 remove useless option from changeIobStatus 2011-07-04 12:15:32 -05:00
Graham Knop
6d4d1af28f convert classLoadTest to WebGUI::Command 2011-07-04 12:15:14 -05:00
Scott Walters
28668d4195 Fix for ``unable to call method setting on undefined value'' when turning admin on. Details follow.
It turned out this problem is related to Moose and/or Class::MOP.  I downgraded Moose to 1.25, and Class::MOP to 1.12, and then I got the console just fine when I clicked on "turn admin on".

I managed to operate the Perl debugger on the code, by putting Enbugger->stop at the desired point. I could then debug it interactively.
The stack trace at the point of failure in Search.pm is:
  DB<3> T
$ = WebGUI::Asset::Wobject::Search::_searchRoot_builder(ref(WebGUI::Asset::Wobject::Search)) called from file `constructor WebGUI::Asset::Wobject::Search::new (defined at /home/amir/Downloads/webgui/lib/WebGUI/Asset/Wobject/Search.pm line 214)' line 224
$ = WebGUI::Asset::Wobject::Search::new('WebGUI::Asset::Wobject::Search', ref(HASH)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Asset.pm' line 1937
$ = WebGUI::Asset::newByPropertyHashRef('WebGUI::Asset', ref(WebGUI::Session), ref(HASH)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Admin.pm' line 186
@ = WebGUI::Admin::getAssetTypes(ref(WebGUI::Admin)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Admin.pm' line 279
$ = WebGUI::Admin::getNewContentTemplateVars(ref(WebGUI::Admin)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Admin.pm' line 811
$ = WebGUI::Admin::www_view(ref(WebGUI::Admin)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Content/Admin.pm' line 80
$ = WebGUI::Content::Admin::handler(ref(WebGUI::Session)) called from file `/home/amir/Downloads/webgui/lib/WebGUI/Pluggable.pm' line 287
$ = WebGUI::Pluggable::run('WebGUI::Content::Admin', 'handler', ref(ARRAY)) called from file `/home/amir/Downloads/webgui/lib/WebGUI.pm' line 165
$ = eval {...} called from file `/home/amir/Downloads/webgui/lib/WebGUI.pm' line 165
. = WebGUI::handle(ref(WebGUI), ref(WebGUI::Session)) called from file `/home/amir/Downloads/webgui/lib/WebGUI.pm' line 77
@ = WebGUI::call(ref(WebGUI), ref(HASH)) called from file `/usr/lib/perl5/site_perl/5.12.3/Plack/Component.pm' line 39

...
  DB<1> l
38==>    my $session = shift->session;
39    return $session->setting->get("defaultPage");
40 }
41 property classLimiter => (
42                fieldType       => "checkList",
43                default         => undef,
44                vertical        => 1,
45                tab             => "properties",
46                hoverHelp       => ["class limiter description", 'Asset_Search'],
47                label           => ["class limiter", 'Asset_Search'],
  DB<1> p join(",",keys %{$_[0]});
mobileStyleTemplateId,displayTitle,assetSize,classLimiter,newWindow,extraHeadTagsPacked,ownerUserId,extraHeadTags,paginateAfter,isPrototype,isPackage,isHidden,groupIdEdit,encryptPage,inheritUrlFromParent,description,isExportable,lastModified,groupIdView,printableStyleTemplateId

NOTE: "session" is not found there.

With a downgraded Moose:

38==>    my $session = shift->session;
39    return $session->setting->get("defaultPage");
40 }
41 property classLimiter => (
42                fieldType       => "checkList",
43                default         => undef,
44                vertical        => 1,
45                tab             => "properties",
46                hoverHelp       => ["class limiter description", 'Asset_Search'],
47                label           => ["class limiter", 'Asset_Search'],
  DB<1> p  join(",",keys %{$_[0]});
skipNotification,uiLevel,displayTitle,classLimiter,newWindow,synopsis,extraHeadTagsPacked,extraHeadTags,ownerUserId,session,paginateAfter,isHidden,groupIdEdit,encryptPage,inheritUrlFromParent,description,title,printableStyleTemplateId
  DB<2>

("session" is found.)

Amir
2011-07-01 16:31:48 -04:00
Colin Kuskie
2bcda0c9f5 Change the generic tax driver to remove spaces around commas when adding a new row. Add tests and a convenience method for getting one line of tax information. Upgrade sub fixes any information already in the db. 2011-06-30 16:20:14 -07:00
Scott Walters
6ac46be8bd Missed upgrade script for the FormField macro. Here's it. 2011-06-30 14:41:50 -04:00
Scott Walters
580cb361cf Merge pull request #16 from ampli/WebGUI8
Web gui8
2011-06-29 17:30:44 -07:00
ampli
f0d5a29e29 findBrokenAssets.pl: redundant argument in WebGUI::Session->open() (#12181)
Problem:
Doesn't work, prints an error message:
Couldn't parse JSON in config file '/'

Fix:
WebGUI::Session->open() is called with $webguiRoot as first arguments, and it should not be supplied any more due to an API change.
2011-06-30 02:59:04 +03:00
Scott Walters
54ae754ebe Repeat ampli's fix (described below) for other occurances on the site.
``The Save buttons in the two first steps didn't work in Chrome.
    According to a hint in the YUI Button documentation about a problem in using
    "submit" as a value of the name attribute, I changed submit button name
    in the two first steps from "submit" to "send".  This solved the problem.''
2011-06-29 19:13:18 -04:00
Scott Walters
747f439725 FormField macro for throwing Form controls directly into templates;
useful for using alternative or improved Form controls without having
to change Asset source code.
2011-06-29 18:11:46 -04:00
Doug Bell
9cc5e2270a proper accredation 2011-06-29 18:09:14 -04:00
Doug Bell
4287f2e10a update changelog 2011-06-29 18:03:52 -04:00
Doug Bell
d448919e4d Merge pull request #15 from ampli/master
DataTable: random deletion of columns may happen when a schema is saved  (#12178)
2011-06-29 14:55:35 -07:00
ampli
5ea09092ad Fixed the following jslint warnings:
Lint at line 5 character 16: 'WebGUI' was used before it was defined.
var WebGUI = {};

Lint at line 53 character 86: Missing '()' invoking a constructor.
data[ columns[ i ].key ] = columns[i].formatter == "date" ? new Date : "";

Lint at line 89 character 21: 'i' is already defined.
for ( var i = 0; i < cols.length; i++ ) {

Lint at line 612 character 25: 'col' is already defined.
var col     = this.dataTable.getColumn( oldKey );

Lint at line 661 character 63: Missing '()' invoking a constructor.
allRecords[j].setData(newKey, new Date);
2011-06-29 04:55:59 +03:00
ampli
8e7beabaf0 Fix #12179.
In WebKit browsers, when a schema is saved, existing column
field types are reset to "Text". This is not a bug in WebKit, and
will happen in any browser that implements Option() as documented.

Option() is not supposed to have an immediate action if only the
default selection is updated on a newly added select object.
See: http://download.oracle.com/docs/cd/E19957-01/816-6408-10/option.htm .

Repeat-By:
1. New Content->basic->Datatable
2. data
3. Edit Schema
4. col1, Number, Add Column
5. col2, E-mail, Add Column
6. col3, URL, Add Column
7. Edit Schema (note that the field types got reset to "Text")
8  Save (now the field types incorrectly got overwritten in the DataTable)

Fixed by adding 4th arguments to actually make the new selection to be
equal to the default one.
2011-06-29 04:12:02 +03:00
Colin Kuskie
814845b7f1 Do not call group methods on an undefined value. IOW, do not assume that we got a group. 2011-06-28 17:16:09 -07:00
ampli
ed0c400440 Columns in DataTable may be "randomly" deleted. This happens in updateSchema(), because both the column update loop and the row update loop use the same variable "i". Since variable scope in JS is by function and not block, the column loop variable gets overwritten.
Repeat-by:
1. New Content->Basic->DataTable
2. data
3. Edit Schema
4. col1, add Column
5. col2, add Column
6. col3, Save
7. Edit Schema

Note that col2 is missing.

Fix:
Change the name of the variable in the row loop.
2011-06-29 03:01:15 +03:00
Colin Kuskie
3fa9d82bcd Ready for 7.10.20 development. 2011-06-27 22:07:50 -07:00
Colin Kuskie
9ab05adb8f Ready for release of 7.10.19 2011-06-27 21:53:13 -07:00
Colin Kuskie
4027b5b4d8 Perform the check BEFORE saving the Thing properties. Fixes bug #12157. 2011-06-27 21:32:57 -07:00
Colin Kuskie
ac8d95e20a Okay, I guess we really do need that. 2011-06-27 21:11:37 -07:00
Colin Kuskie
204108e178 Remove the Underground User style template, and fix the problem is tried to fix by changing the navigation. Fixes bug #12172 2011-06-27 18:06:23 -07:00
ampli
ebbbeb6609 The Save buttons in the two first steps didn't work in Chrome.
According to a hint in the YUI Button documentation about a problem in using
"submit" as a value of the name attribute, I changed submit button name
in the two first steps from "submit" to "send".  This solved the problem.
2011-06-28 03:34:24 +03:00
Colin Kuskie
720c06a50a Fix template help variables for month/year in the Calendar. Fixes bug #12167. 2011-06-27 15:10:34 -07:00
Colin Kuskie
f728b22843 Do not append ;adminId to the URL stored for calendar feeds. Add upgrade code to fixing existing, broken feeds. Fixes bug #12164 2011-06-27 14:40:46 -07:00
khenn
97ec859653 Localized a global variable which interferes with other third party js packages. 2011-06-26 12:06:45 -05:00
Doug Bell
f797429b5f clarify docs 2011-06-24 15:09:25 -05:00
Doug Bell
9a90ad6d2f add forms to templates to work directly with FormBuilder objects 2011-06-24 15:08:51 -05:00
Doug Bell
199e2240a7 Revert "allow SSLPROXY header again"
This reverts commit e8d1fa0056.

SSLPROXY should be handled by using Plack::Middleware::ReverseProxy and
setting the X-Forwarded-Proto http header to "https"
2011-06-23 17:46:16 -05:00
Doug Bell
e8d1fa0056 allow SSLPROXY header again 2011-06-23 17:35:58 -05:00
Doug Bell
b1660fe76b document that tableKey is not allowed to have fieldType 2011-06-23 13:07:19 -05:00
Doug Bell
7f47927325 use a default label instead of requiring one 2011-06-23 13:02:27 -05:00
Paul Driver
3acaa46713 fixed #12169: extras uploads symlink export 2011-06-21 16:16:51 -05:00
Doug Bell
0c5acb697b Merge commit 'v7.10.18' into 8
Conflicts:
	docs/gotcha.txt
	docs/previousVersion.sql
	docs/templates.txt
	lib/WebGUI.pm
	lib/WebGUI/Asset/File.pm
	lib/WebGUI/Asset/Story.pm
	lib/WebGUI/Asset/Wobject/Calendar.pm
	lib/WebGUI/Asset/Wobject/Thingy.pm
	lib/WebGUI/AssetExportHtml.pm
	lib/WebGUI/Content/AssetManager.pm
	lib/WebGUI/Group.pm
	lib/WebGUI/Macro/AssetProxy.pm
	lib/WebGUI/Shop/PayDriver/PayPal/PayPalStd.pm
	lib/WebGUI/Storage.pm
	t/Asset/AssetExportHtml.t
	t/Asset/Story.t
	t/Shop/TaxDriver/Generic.t
	t/Storage.t
2011-06-21 16:03:49 -05:00
Doug Bell
4d0e87a8d9 add ticket limits to badge groups. add ticket and badge metadata to templates 2011-06-20 18:39:45 -05:00
Doug Bell
d0077bdcec allow specific expires dates for groups in userImport.pl 2011-06-20 18:26:39 -05:00
Chris Hanson
07d2c38dbc Monday morning. Typo correction to 8a6ba94..c646f01 2011-06-20 11:45:29 -05:00
Chris Hanson
c646f012ae Added template var to Thingy to reflect callerAssetId from RenderThingData. 2011-06-20 11:38:02 -05:00
Doug Bell
02c0da33e4 Merge remote-tracking branch 'upstream/WebGUI8' into 8
Conflicts:
	docs/previousVersion.sql
2011-06-17 20:15:24 -05:00
Doug Bell
795d88e7e5 Merge commit 'v7.10.17' into 8
Conflicts:
	docs/upgrades/upgrade_7.9.13-7.10.0.pl
	lib/WebGUI.pm
	lib/WebGUI/Asset/Template/TemplateToolkit.pm
	lib/WebGUI/Asset/Wobject/AssetReport.pm
	lib/WebGUI/Asset/Wobject/Thingy.pm
	lib/WebGUI/Form/Captcha.pm
	lib/WebGUI/Macro/AdminBar.pm
	lib/WebGUI/Shop/Cart.pm
	lib/WebGUI/Shop/PayDriver.pm
	lib/WebGUI/Shop/PayDriver/PayPal/ExpressCheckout.pm
	lib/WebGUI/Shop/PayDriver/PayPal/PayPalStd.pm
	lib/WebGUI/Shop/Transaction.pm
	lib/WebGUI/Workflow/Instance.pm
	lib/WebGUI/Workflow/Spectre.pm
	lib/WebGUI/i18n/English/PayDriver.pm
	t/Asset/Asset.t
	t/Asset/AssetExportHtml.t
	t/Asset/AssetLineage.t
	t/Asset/Wobject/Thingy.t
2011-06-17 20:13:41 -05:00
Chris Hanson
8a6ba94191 Added POD and test for RenderThingData macro update 2011-06-16 18:07:54 -05:00
Doug Bell
1d23bcf846 Merge pull request #13 from haarg/template_proxy
Template proxy to prevent modifying properties inside templates
2011-06-16 16:06:20 -07:00